The tableselect element processing always adds a column to the output table for the check boxes or radio buttons, but does not always add a column header. If a tableselect item has #multiple_value = FALSE, then a column header is missing in the table.

CommentFileSizeAuthor
#10 891476-core-tableselect.patch1001 bytessolotandem
#7 891476-core-tableselect.patch807 bytessolotandem
#5 891476-core-tableselect.patch991 bytessolotandem
#4 891476-core-tableselect.patch690 bytessolotandem
#1 891476-core-tableselect.patch691 bytessolotandem
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

solotandem’s picture

solotandem CreditAttribution: solotandem commented
Status: Active » Needs review
FileSize
891476-core-tableselect.patch691 bytes
boombatower’s picture

boombatower CreditAttribution: boombatower commented
Status: Needs review » Reviewed & tested by the community

looks good

Heine’s picture

Heine CreditAttribution: Heine commented

Duplicate of #888782: regression: tableselect headers misaligned when #js_select is FALSE. But since this exact same patch is RTBC, marking that one closed.

solotandem’s picture

solotandem CreditAttribution: solotandem commented
FileSize
891476-core-tableselect.patch690 bytes

Rerolled.

solotandem’s picture

solotandem CreditAttribution: solotandem commented
FileSize
891476-core-tableselect.patch991 bytes

Added comment at suggestion of webchick.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 891476-core-tableselect.patch, failed testing.

solotandem’s picture

solotandem CreditAttribution: solotandem commented
Status: Needs work » Reviewed & tested by the community
FileSize
891476-core-tableselect.patch807 bytes

Revised comment from IRC discussion with Heine.

Heine’s picture

Heine CreditAttribution: Heine commented

The comment is misleading; the empty header is not only necessary when displaying radios, but also when the select-all checkbox is not displayed when checkboxes are displayed. In either case #js_select is FALSE.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 891476-core-tableselect.patch, failed testing.

solotandem’s picture

solotandem CreditAttribution: solotandem commented
Status: Needs work » Reviewed & tested by the community
FileSize
891476-core-tableselect.patch1001 bytes

Reworded the comment and rerolled against HEAD.

ruharen’s picture

ruharen CreditAttribution: ruharen commented

Ignore this. My mistake.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented

#10: 891476-core-tableselect.patch queued for re-testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Version: 7.x-dev » 8.x-dev

Although badly needed, this is D8 material according to the rules (I had to learn today). It may be backported at a later point in time (though that's unlikely).

Heine’s picture

Heine CreditAttribution: Heine commented
Version: 8.x-dev » 7.x-dev

I call BS on this. I also don't feel happy that this simple comment change is collateral damage / serves as counter example in some policy fight.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.