Hey,

Just a very small issue that should hopefully be no real problem for you. I have a system with the Image and Lightbox2 modules installed, as well as the File Force module which updates the different image links (original, thumbnail, preview) into file force links. All that works well, but an issue is that the implementation of Lightbox2's hook_link_alter changes the image links even if the automatic handler for Image nodes is set to "Disabled" on admin/settings/lightbox2/automatic, where it should really do nothing and give the other modules a chance :)

Yes, if I remove all image sizes from the "Image trigger size" just below that, this problem goes away. But you have to admit that if something is set to "disabled", one should not worry about cleaning up all the previous settings.. and while I can do it, this is even harder to explain to clients.

All that is needed to fix is something like a "if ($image_node_handler) {" clause around the "foreach ($trigger_sizes as $size) {" loop at the end of hook_link_alter.

Please let me know what you think, and I'd also be happy to provide a patch if necessary.

Thanks a lot!

Cheers,
Martin

Comments

stella’s picture

Status: Active » Fixed

Fix committed, thanks.

arski’s picture

cheers! :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.