When for example extending a Query with PagerDefault and that has an error, the error tells you only that you are using PagerDefault but not where :)

Patch simply checks if the class implements QueryExtendableInterface...

CommentFileSizeAuthor
#4 filter_out_extenders2.patch924 bytesBerdir
filter_out_extenders.patch928 bytesBerdir
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Crell’s picture

Crell CreditAttribution: Crell commented
Status: Needs review » Needs work

Shouldn't it be SelectQueryExtender? QueryExtendableInterface is the one on Select itself, saying it CAN be extended. It's not what's on the ExtendER, but the ExtendEE.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

every extender can be extended itself, so it doesn't really matter :)

SelectQueryExtender implements SelectQueryInterface which extends QueryExtendableInterface.

So any of these works technically but I'm happy to change it if you think that another one makes more sense logically.

Crell’s picture

Crell CreditAttribution: Crell commented

Well bah!

I suppose we could do both... I mean, we want to skip both of them in the stack trace, right? :-)

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs work » Needs review
FileSize
filter_out_extenders2.patch924 bytes

Hm, I don't think both makes any sense because SelectQueryInterface extends from QueryExtendableInterface, so checking SelectQueryInterface automatically includes QueryExtendableInterface.

However, in all other Places where we check an interface, we use SelectQueryInterface, so I updated the patch to use that one.

Status: Needs review » Needs work

The last submitted patch, filter_out_extenders2.patch, failed testing.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs work » Needs review

#4: filter_out_extenders2.patch queued for re-testing.