Performance: Avoid using the %views_arg menu loader if argument does not need validation. [#881680]

According to merlinofchaos, the %views_arg menu loader is only necessary if the argument needs to be validated. Attached patch adds logic to avoid using the menu loader if the related argument doesn't require any validation.

Comment	File	Size	Author
#2	881680-unnecessary-autoloaders.patch	869 bytes	longwave
#2
#1	page_plugin_remove_unecessary_autoloaders-6X-3X-rev2.patch	1.25 KB	brianV
#1
	page_plugin_remove_unecessary_autoloaders-6X-3X.patch	1.28 KB	brianV

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

brianV CreditAttribution: brianV commented 12 August 2010 at 20:19

File	Size
page_plugin_remove_unecessary_autoloaders-6X-3X-rev2.patch	1.25 KB

Doh. Text editor inserted the changed code where I thought I told it to overwrite.

Revised patch attached.

Comment #2

longwave

he/him

English

CreditAttribution: longwave commented 21 October 2010 at 14:04

File	Size
881680-unnecessary-autoloaders.patch	869 bytes

Revised version of the above patch attached. This correctly handles displays with inherited arguments, and also checks the correct "no validation" type, which is "none" instead of "default".

Comment #3

dawehner

German

CreditAttribution: dawehner commented 21 October 2010 at 18:58

Status:

Needs review

» Reviewed & tested by the community

* Both in views2 and views3 the validate_type is "none".
* Manual testing of the feature worked fine. (checking the menu router item)
* Code looks fine

Comment #4

merlinofchaos CreditAttribution: merlinofchaos commented 16 November 2010 at 00:50

Status:

Reviewed & tested by the community

» Needs review

$key = $name . ':' . $display_id . ':' . $value . ':' . $index;

Then use $key in all the places the calculation is used.

The only place that : is a valid value is $value so you shouldn't get any weird combinations that can masquerade as other combinations.

Comment #5

merlinofchaos CreditAttribution: merlinofchaos commented 16 November 2010 at 00:55

Status:

Needs review

» Reviewed & tested by the community

Disregard #4, wrong issue.

Comment #6

merlinofchaos CreditAttribution: merlinofchaos commented 16 November 2010 at 01:00

Status:

Reviewed & tested by the community

» Fixed

Patches like this remind me that the project has gotten so big that easy, obvious fixes don't happen just because they're so small I never get to them in the giant pile of things I can do. I know this should happen but when I sit down to work, it never ends up on my plate.

I'm glad someone else did this, because the patch is dirt simple and a good improvement. Applied to all branches.