Support non-serial ID for vocabularies [#875212]

The extractor module currently stores and refers to the lookup vocabulary by its serial vid. This prevents you from consistently referring a particular vocabulary that has been exported using the Features module. This module should be patched to allow the option to use the non-serial "module name" to identify the vocabulary.

Comment	File	Size	Author
#5	836878_7.patch	7.87 KB	alex_b
#3	875212_2.patch	2.16 KB	Will White
#1	875212_1.patch	2.16 KB	Will White

Comments

Comment #1

Will White commented 5 August 2010 at 21:13

Status:

Active

» Needs review

Status	File	Size
new	875212_1.patch	2.16 KB

Patch attached.

Comment #2

alex_b commented 20 August 2010 at 06:36

Status:

Needs review

» Needs work

double quotes (") in SQL statements don't conform to the standard, this would throw off PGSQL.

Have you done any performance testing on the WHERE v.module = "%s" query? The number of selected items overall is high, while the number of vocabularies is usually very slow. I guess we are fine - unless the overall number of selected items requires an index no matter how low the number of items of the table we join to and filter by is (vocabulary)...