when a region is empty, its wrapper is still printed, resulting in empty (and pretty damn useless) elements

Comments

jensimmons’s picture

jensimmons commented
Status: Active » Closed (won't fix)

This is not relevant. It's much too early for this kind of code review.

ajpiano’s picture

ajpiano commented

If this is irrelevant, why will it be worth reviewing at some point in the future?
If it is worth reviewing at some point in the future, why is it irrelevant?
If it is then, indeed, relevant, why is it not relevant today?

jacine’s picture

jacine
she/her
Location New York
commented

ajpiano - because the code that was reviewed was (a) not yet worked on in reference to this project and (b) it's not even being used anymore. Work was started with an existing base theme called the mothership, which has since been removed in order to start fresh.