CVS edit link for coolestdude1

I plan to contribute a dynamic banner module to lighten the load on drupal created blocks.
This module will read from the drupal database to automatically decide which banner goes on which page.
This module will be able to be used in many different ways and is extremely reusable.
I will be needing some help to make this module organized and fully compatible with the api.
I also want to help my co-worker with his module in making a fully fledged scorm compatible interface for drupal.

Comments

coolestdude1’s picture

StatusFileSize
new5.92 KB

here is the necessary module for review.

Module supports page specific banners, wild card banners, and randomized banners.

It will dynamically create a block for you where the banner will be printed into your template (add it to a panel if you want).

At the moment a template file has not been created but in the future there will be one.

Still needs work so as soon as approved more work will be submitted.

coolestdude1’s picture

Status: Postponed (maintainer needs more info) » Needs review

should have read all of email haha

coolestdude1’s picture

StatusFileSize
new86.64 KB
new274.25 KB

Attached two screen shots one of the banner in action and one of the admin page please take a look.

Also note this module would be sponsored by NP Training Works (the company i work for and made this for, i already have permission from them to do so)

avpaderno’s picture

Issue tags: +Module review

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.

coolestdude1’s picture

StatusFileSize
new6.4 KB

Been working on it today here is the latest copy.
Implemented template files.
Implemented default banner.

coolestdude1’s picture

StatusFileSize
new6.54 KB

Ok went thru and tested fixed some more things associated with default should be working great now.
Made code more messy will be seeking to clean it up soon

coolestdude1’s picture

I am currently working on getting a settings page up so that you have a few predetermined outputs of the banner. Like if you want it to have just and image or text and image or maybe even and image and a part of the node. This is about a week down the line and will change the look and feel of the module hopefully for the best.

Also has anyone had a chance to look at my code yet?

Probably within the next day or two i will write a better description and how to for my own module.

coolestdude1’s picture

StatusFileSize
new6.67 KB

I re-packaged the module. I found some coding standard mistakes
Added in the $id for packaging script
Enhanced the help.
And other minor changes

Still coming
-Settings Page - one possible setting could be if it looks for the random or wild card at all , another could be if the image is set but the text is random , or if the text comes from a node
-Image uploader and chooser

Questions
-For permissions can some one tell me if i did that correctly cause it is technically working but just wanted to make sure it is up to code standards.

coolestdude1’s picture

StatusFileSize
new6.75 KB

I just finished crunching the module thru the coder module as i see other people doing so i might as well.
Fixed some update / adding a banner problems.
Added in the skeleton that is the settings database.
Fixed some dbid problems.

coolestdude1’s picture

Anyone? Its been 3 weeks now...
Can someone come and sign off on this thing?

Latest Developments
- found out that i am doing settings the wrong way so i am working on converting it to use drupal variable set
- fixing other ui issues

coolestdude1’s picture

StatusFileSize
new6.84 KB

Fixed and reimplemented settings.

Still todo
-now that the logic is down for settings all that needs to be done is to create a page that an admin can go to and change them.
-better examples

avpaderno’s picture

Hello, coolestdude1.
Reviews for CVS applications require a little of time because, as you see, there are a lot of CVS applications; all of them require more than one review, and that takes time.

If you have a new version of the module, it should be better if you attach it in a new comment, to avoid that who reviews the code reports something that you have already corrected.

coolestdude1’s picture

StatusFileSize
new7.39 KB

Thanks kiamlaluno will do.
Ok settings are now working... Fixed and removed sections that were unnecessary.
I am safe to say this is RC1 for this module
Also my site is now live a preview of this work can be found here (@ http://www.nptrainingworks.com)

avpaderno’s picture

Assigned: Unassigned » avpaderno

I will review the code tomorrow.

avpaderno’s picture

Status: Needs review » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)
Issue tags: -Module review

Automatically closed -- issue fixed for 2 weeks with no activity.

avpaderno’s picture

Component: Miscellaneous » new project application
Issue summary: View changes
Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.