valante [valante] [#866100]

CVS edit link for valante

I've been contributing to the TableQuote module for a while, and would like to make it official. Among my contributions you will find a cleaner version of the code for better performance, field and overview formatting for better user experience, bug fixes, and new features (soon to be posted).

Here's the relevant issue: http://drupal.org/node/864192

Please let me know if there's any other information you need.

Many thanks,
Tal Valante

Comment	File	Size	Author
#1	new_uc_tablequote.zip	4.3 KB	valante
#1	project_page.txt	1.48 KB	valante

Comments

Comment #1

valante commented 27 July 2010 at 13:56

Status:

Postponed (maintainer needs more info)

» Needs review

Status	File	Size
new	project_page.txt	1.48 KB
new	new_uc_tablequote.zip	4.3 KB

Hello,

Attached is my cleaner version of the Ubercart TableQuote module (sans new features). Also attached, a project page I've written for the module by Henri's request.

Best,
Tal

Comment #2

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 27 July 2010 at 15:47

Status:	Needs review	» Needs work
Issue tags:		+Module review

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.

As per requirements, the motivation message should be expanded to contain more features of the proposed project. For themes, it should include also a screenshot of the theme, and (when possible) a link to a working demo site using the proposed theme; for modules, it should include also a comparison with the existing solutions.

Comment #3

valante commented 27 July 2010 at 21:01

Thank you for the prompt reply!

I'm not sure how to expand upon the motivation clause. I'm not offering a new module, only applying for co-moderation of an existing one. I've attached my new version of the project page, and the new version of the module. Should I list the changes I've made to the code one by one?

Best,
Tal

Comment #4

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 28 July 2010 at 00:39

Status:

Needs work

» Fixed

In that case, you should have reported that the application is for co-maintaining an existing project.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.