I had to change the from header in action_send_email because some smtp servers choke on the "< .*>" syntax.

I simply changed

  $from = "$site_name <" . variable_get('site_mail', ini_get('sendmail_from')) . '>';

to

  $from = variable_get('site_mail', ini_get('sendmail_from'));

to get things to work properly.

CommentFileSizeAuthor
#3 actions.inc_bad_from.patch666 bytespearcec
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pearcec’s picture

pearcec CreditAttribution: pearcec commented
Status: Active » Reviewed & tested by the community

This is how it is done is user.module. I would change it in CVS just for consistency.

jvandyk’s picture

jvandyk CreditAttribution: jvandyk commented
Status: Reviewed & tested by the community » Fixed

Fixed. Thanks.

pearcec’s picture

pearcec CreditAttribution: pearcec commented
Status: Fixed » Reviewed & tested by the community
FileSize
actions.inc_bad_from.patch666 bytes

I had another issue with the from address. I don't think I need to open another issue. I already have the patch.

I was getting this as the from address:

"=?UTF-8?B?RnJvbTogaW5mb0BhYm91dC5pbmZvClJlcGx5LXRvOiBpbmZvQGFib3V0LmluZm8=?=.=?UTF-8?B?ClgtTWFpbGVyOiBEcnVwYWwKUmV0dXJuLXBhdGg6IGluZm9AYWJvdXQuaW5mbwo=?=.=?UTF-8?B?RXJyb3JzLXRvOiBpbmZvQGFib3V0LmluZm8=?=@localhost.localdomain"

When I compared it to the user.module, it simply used $from in the drupal_mail function call. Instead of having all the other header information. Seems drupal_mail puts all that header information in anyway.

Pomliane’s picture

Pomliane CreditAttribution: Pomliane commented
Status: Reviewed & tested by the community » Closed (won't fix)

This version of Actions is not supported anymore. The issue is closed for this reason.
Please upgrade to a supported version and feel free to reopen the issue on the new version if applicable.

This issue has been automagically closed by a script.