Closed (fixed)
Project:
Location
Version:
6.x-3.1
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
23 Jul 2010 at 04:55 UTC
Updated:
17 Jan 2011 at 08:00 UTC
In the function location_geocode_au_google() there is a line if ($accuracy_code != 8 && $accuracy_code != 7)
I have found on numerous sites that this threshold is too high. For example if I search Google Maps for "Eildon Road Jamieson VIC" I get the location just fine, but accuracy is apparently 6, so location module ignores it.
I think the code should read if ($accuracy_code < 6)
Comments
Comment #1
yesct commentedThere might be an issue in the queue for making the accuracy threshold a setting via the ui.
We might need someone to search the issue queue and look for issues involving the level of accuracy.
Comment #2
hutch commented@YesCT, is this the one? #503468: Make Google geocoding minimum accuracy a variable
Comment #3
yesct commentedyeah, that doesn't make a UI, right? just a var in code?
And this, #547418: Google Maps API v3 might depreciate the accuracy variable.. I think if I read it right... that is, if a setting can be made to let in the non perfect results.
Comment #4
rooby commentedThis should have been using the "Google Maps Geocoding Accuracy" setting from admin/settings/location/geocoding/au/google instead of hard coding the accuracy level.
This has been fixed in all branches. You can now use that setting to set the desired level of accuracy.
http://drupal.org/cvs?commit=473162
http://drupal.org/cvs?commit=473160
http://drupal.org/cvs?commit=473164