A regular user gets three status options in the edit screen for her subscriptions (user/N/notifications/subscriptions/edit/NNN):
- active
- inactive
- disabled
(The 'blocked' status is properly filtered out. The 'disabled' status isn't.)

This is unclear (and I'm placing this in production) so I wanted to get rid of the 'disabled' status.

First I thought, let's just scrap 'disabled' in this screen always, and scrap the links to the edit screen (from the overview) for 'disabled' subscriptions, and be done with it.

On second thought, there's a different solution... one really shouldn't be able to change individual subscriptions from active <-> disabled. So this patch always filters out one of those 2 options. I also included a more elaborate description, in case 'disabled' is among the choices.

---

Issues:

- There's one thing that is not accounted for yet: changint disabled->active subscriptions 'in bulk', in the user/N/notifications/subscriptions list. Should that be prevented too? (I'll include this in the patch somehow if you want me to, but that's not urgent for my site.)

- The order of options has 'blocked' as the 2nd choice. I'd like it to be 4th (or 3rd) so active/inactive are always adjacent.
Am I allowed to change the order in Notifications_Subscription::status_list()? :-)

Comments

ezeedub’s picture

Version: 6.x-4.x-dev » 6.x-4.0-beta7
Status: Needs review » Reviewed & tested by the community

Patch worked for 6.x-4.0-beta7. Thanks

roderik’s picture

StatusFileSize
new596 bytes

...but you did have to apply the patch by hand :)
(one line of context has changed.)

roderik’s picture

StatusFileSize
new2.3 KB

DO NOT USE ABOVE. Patch for wrong issue, sorry.

  • Nafes committed a4b45e9 on 6.x-4.x authored by roderik
    Issue #862258 by roderik: Status options in the subscription edit screen
    
Nafes’s picture

Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Committed. Thanks roderik!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.