Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.As we saw in many other cases like support for mssql or oracle it
would be fine to be able to override it for the db-type. In d6 you need to write a query backend to support it, also for d7 you only can support the other databases if you can alter views_date_sql_field.
So this patch
* moves views_date_sql_field to the query backend.
* keeps views_date_sql_field as a wrapper.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | views-858118-date_sql_0.patch | 10.55 KB | dawehner |
| #3 | views-858118-date_sql.patch | 9.98 KB | dawehner |
| #1 | views-858118-date_sql.patch | 8.1 KB | dawehner |
Comments
Comment #1
dawehnerThe same for views_date_sql_extract and views_date_sql_format
Comment #2
miro_dietikerLooks straightforward to me and makes the backend more pluggable.
Comment #3
dawehnerDo the same for views_get_timezone
Perhaps this functions could be removed and the query backend could directly call $this->$function
Comment #4
merlinofchaos CreditAttribution: merlinofchaos commentedRecent commits cause this to not apply. Whoops.
That said, I'm in favor of this; please make sure we do some actual testing of it to make sure existing date stuff does not break?
Comment #5
dawehnerRerole
#needs more testing
Comment #6
miro_dietikerlooks (visually) fine to me. no application and coderun tested.
Comment #7
merlinofchaos CreditAttribution: merlinofchaos commentedWhat's the possibility of these functions being called without a view?
Well, in Views itself, the answer is 'never'. Obviously we can't know what people outside Views are doing. But we should probably have a fallback condition for that case.
Additionally, a quick grep shows that everywhere Views calls any of these functions, we have a view already. We should shortcut things and call directly to $view->query->$function so we don't have to go through the global wrapper function.
We can then mark the global wrapper function as @deprecated, and just remove it in D7 and require all contrib modules to use the new functions.
Comment #8
dawehnerWe could call the method statically.
Comment #9
MustangGB CreditAttribution: MustangGB commented