nicola.puddu [nicolapuddu]

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.

As per requirements, the motivation message should be expanded to contain more features of the proposed project. For themes, it should include also a screenshot of the theme, and (when possible) a link to a working demo site using the proposed theme; for modules, it should include also a comparison with the existing solutions.

The use case of the proposed module, as described, seems to be too specific to be useful for other site, expect for sites about Lombardy. Does SIRBeC use a specific XML format, or is it generic enough? Why didn't you create a feature request for the existing project, rather than creating a new module?

As per instructions, you need to attach here the archive containing the code; differently, the application cannot continue.

The argument passed to t() is the English string to translate; the proposed module is using Italian strings. The same is true for all the strings that appears in the user interface, which includes the description, and the title given to menu callbacks.

I would also suggest to rename the module because the module name is in Italian, and it makes seems the module specific for use case.

The code still needs to be changed in some places, but the code doesn't contain any of the mistakes listed in http://drupal.org/node/539608.

1. /**
    * @file
    * Implementation of FeedsParser::parse().
    *
    */
   

   That comment is referring to a method; it's not the comment that should be used to describe a .inc file.

2. $guid = !empty($scheda->CD->ISK) ? "{$scheda->CD->ISK}" : $scheda->CD->ISK;
   

   The code should be rewritten as

   $guid = !empty($scheda->CD->ISK) ? $scheda->CD->ISK : "";
   

   If $scheda->CD->ISK is not of the desired datatype, then it should be casted.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.