In DatabaseInvalidDataTestCase::testInsertDuplicateData() we test that if one insert fails, the whole transaction is rolled back. This is the standard behavior of MySQL, but we don't actually enforce it in the base InsertQuery implementation. As a consequence, this test fails on SQLite, which uses the default implementation.

CommentFileSizeAuthor
#1 851110-insert-rollback.patch1.33 KBdamien tournoud

Comments

damien tournoud’s picture

damien tournoud commented
Status: Active » Needs review
StatusFileSize
new 851110-insert-rollback.patch1.33 KB
Stevel’s picture

Stevel commented
Status: Needs review » Reviewed & tested by the community

Looks good, and the tests invalid data test case works on sqlite with this patch.

Crell’s picture

Crell commented

Have we tested this offline with both SQLite and Postgres? (MySQL obviously is unaffected by this patch either way, so the Green means nothing.)

damien tournoud’s picture

damien tournoud commented

@Crell: for SQLite: #543582-16: Meta issue: fix the remaining SQLite bugs

PostgreSQL doesn't use the base implementation.

Crell’s picture

Crell commented

Good enough for me. Nice blitzing today, DamZ!

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.