Artman [artman]

Hello, and thanks for applying for a CVS account.

1. See http://drupal.org/coding-standards to understand how a module should be written.

2. function lottery_block_install() {
   
     // Set up our default variables
     $data = array(
                   'state' => 'FL',
                   'pause_delay' => '3000',
   		'show_header' => TRUE,
   		'two_line_header' => TRUE,
   		'footer_text' => 'Mouseover To Pause',
   		'show_analysis_link' => TRUE,
                 );
     
     variable_set('lottery_block_settings', $data);
   
     drupal_set_message(t('Lottery Block Module Installed! Go to Administer->Site Building->Blocks->Lottery Block to configure your parameters.'));
   }
   

   Drupal variables are not initialized during installation.

3.     // Load our block settings
       $data = variable_get('lottery_block_settings', FALSE);
       
       // Open our XML feed file from us-lotteries.com
       $source = 'http://www.us-lotteries.com/rss/'.$data['state'].'Rss.xml';
       $RSSfeed = fopen($source, "r");
   
       // Let's parse the information
       $LotteryData = array();
       $i = 0;
   
       while($line = fgets($RSSfeed)) {
       
           if (strstr($line, '<item>')) {
   	    
   	    while($line = fgets($RSSfeed)) {
   	        if (strstr($line, '</item>')) {
   		    break;
   		}
   

   The code would not work, if fopen() is not allowed to read remote files. Why isn't the code using the function that Drupal has to get content from an external site?

4. Files available from third-party sites should not committed in Drupal.org. The comment that is present at the beginning of the file makes me think the file is not released under GPL license.

The function _lottery_block_content() is outputting too much HTML; you should be using a theme function.

5.       $output = '<p>'.  t("Displays state lottery results in a styleable block.") . '<br />';
         $output .= t("Works with RSS feeds from www.us-lotteries.com and will display lottery results for any one of 44 lottery states (including the District of Columbia). ");
         $output .= t("For more lottery widgets and/or analysis and other data, visit: ") . '<a href="http://www.us-lotteries.com" target="_blank">'.t('US-Lotteries').'</a></p>';
   

   Is the link of any relevance for who has a Drupal site?

See comment #3; there was a missing tag that did mess all the comment.

The link to a third-party site seems more like a spam link.
The link text is For more lottery widgets and/or analysis and other data, visit: , which leads users to think they will find widgets they can use for their Drupal site; the correct link text should probably say Feed content obtained from: .

The function I reported to output too much HTML without to use theme functions is not an implementation of hook_help(); if it would have been, then I would not have reported what I reported.

Please read the following links as this is very important information about CVS applications.

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for these applications. Please read Migrating from CVS Applications to (Git) Full Project Applications and Applying for permission to opt into security advisory coverage on how this affects and benefits you and the application process. In short, every user has now the permissions necessary to create new projects, but they need to apply for opt into security advisory coverage. Without applying, the projects will have a warning on projects that says:

This project is not covered by Drupal’s security advisory policy.