Stocker [stocker]

Please read http://drupal.org/cvs-application/requirements before to apply for a CVS account.

Hello, and thanks for applying for a CVS account.

The requirements report that screenshots should be included, for themes; the size of the screenshots should allow to see how the theme appears.
You could also include a link to demo site using the proposed theme.

Great theme Stocker. Really like the design. After giving the theme some review, here is a couple of things that I'd suggest changing:

Version should be removed from the .info file this information is not necessary as it is added by the Drupal.org packaging script when a release is made. Explanation => http://drupal.org/node/171205#version

LICENSE.txt should be removed, this is also added by Drupal.org.

The only other thing I would suggest is that you put some of your logic into new variables through pre-process functions in the template.php file. Mainly concerning lines 13-15 in node.tpl, and lines 72-73 in page.tpl. Reducing the amount of php to just variables with on MINIMAL logic makes .tpl.php files much cleaner and more readable. Here is an explanation of setting new variables for in tpl files: http://drupal.org/node/223430

Blast it! Tagging.

This is great work Stocker, major improvements this round. Sorry it has taken me so long to get back to this issue. After giving the theme a more detailed look, here's a couple of more changes I would make.
All echo statements should be changed to print. Not absolutely sure why, but it is considered best practice in Drupal to use the print statement.

I really like the twitter icon there, but as of right now it is hardcoded into template.php to link to twitter.com. Most people probably don't want to have a link straight to twitter.com, nor do they want to go into template.php and hard code a specific twitter accounts address. Any chance you could create a theme setting where a user could enter in there twitter url, and then it could be set as the twitter birds link? Make sense? Then, you could just run a check and see if this custom theme setting has been set by the user and if it's not set, not render the birdie at all. Here is a great page that walks through the steps of adding custom theme settings: http://drupal.org/node/177868

Your "Id" comment should be changed from // $Id: to // $Id$. The colon plus CVS commit info is added in place of the second dollar sign.

Lastly, though the CSS formatting guidelines are not finalized yet. We are currently encouraged to indent all CSS properties with two spaces.
Therefore this:

html, body {
margin:0;
padding:0;
}

Should become this:

html, body {
  margin:0;
  padding:0;
}

This theme definitely will be a great addition to the Drupal repository. If these issues are resolved, you've got a RTBC tag from me!

Heck yes! Looks great, definitely one of my favorite themes that I have reviewed for a CVS application yet. Great work.

The next step in this process is one of the Contributions Repository Maintainers (usually kiamlaluno) will come and review your theme/application. Then, they will bring up any last issues about the application (if any), once any issues brought up are resolved. Your CVS application will (hopefully) be approved!

Happy committing.
RTBC++

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.