This seems to be true for all versions of Drupal shown on api.d.o.

Also the function description is weak; a suggestion is in the patch on the first comment.

CommentFileSizeAuthor
#15 filter-module2-D6.patch2.02 KBrdrh555
#12 filter-module-D6.patch1.97 KBrdrh555
#6 834710-filter-xss.patch1.99 KBsolotandem
#5 834710-better-doc.patch1.98 KBjhodgdon
#1 834710-filter-xss.patch1.01 KBsolotandem

Comments

solotandem’s picture

solotandem commented
Status: Active » Needs review
StatusFileSize
new 834710-filter-xss.patch1.01 KB

Patch attached; aimed at D7. Similar changes apply to other versions.

Status: Needs review » Needs work

The last submitted patch, 834710-filter-xss.patch, failed testing.

solotandem’s picture

solotandem commented
Status: Needs work » Needs review

#1: 834710-filter-xss.patch queued for re-testing.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Needs work

Good catch!

However, this proposed documentation does not follow the doc standards.
http://drupal.org/node/1354#functions
- first line verb is wrong tense
- no blank line between @param and @return sections

I also don't like that the first line says it's filtering "for characters". It's doing a lot more than that.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 834710-better-doc.patch1.98 KB

Here's a new patch with rewritten doc.

solotandem’s picture

solotandem commented
Status: Needs review » Needs work
StatusFileSize
new 834710-filter-xss.patch1.99 KB

Slight wording change on function description.

solotandem’s picture

solotandem commented
Status: Needs work » Needs review

Missed the status.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Looks good!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

And as a note, if this patch is accepted, it should be next ported to Drupal 6.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Version: 7.x-dev » 6.x-dev
Status: Fixed » Patch (to be ported)
rdrh555’s picture

rdrh555 commented
Assigned: Unassigned » rdrh555
Status: Patch (to be ported) » Needs review
StatusFileSize
new filter-module-D6.patch1.97 KB

From #6

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Looks fine, thanks!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

Oops, spoke to soon: patch needs to be rolled from the Drupal root.

rdrh555’s picture

rdrh555 commented
Status: Needs work » Needs review
StatusFileSize
new filter-module2-D6.patch2.02 KB

Eclipse setting.....

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

That's it, thanks!

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Thank you, committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.