See screen-shot - this idea of using negative margin to position the percentages on top of the bar needs work.
bartik-poll-percentages.png

Comments

Jeff Burnz’s picture

StatusFileSize
new6.12 KB

Bah, stupid screen shot software buggered it up, lets try that again...

Nope, ignore this one also!

Jeff Burnz’s picture

StatusFileSize
new4.34 KB

maybe this time?
poll.gif

jensimmons’s picture

Yeah. I worked for a while to prevent the overlay.... but guess my strategy didn't prevent all of it.

Any ideas?

Jeff Burnz’s picture

Probably...

.poll .text {
clear:right;
margin-right:2.25em;
}

Sorry, I have no time to roll patches and test atm.

Thinking the percentage only needs a neg margin of 3em, rather than 3.2, seem to sit too high?.

Jeff Burnz’s picture

This also needs fixing in RTL, the percentages look like they're floated, so need RTL override.

sarah_p’s picture

StatusFileSize
new459 bytes

Here is a screenshot and a patch for the above code modified to 5em to give full clearance. Currently this is just the LTR.

OSX 10.6
Firefox 3.6.3

screenshot -- http://img.skitch.com/20100623-gbdt7w645qeqsb1r9y2p9r43j3.pdf

Jeff Burnz’s picture

Needs different values for the block, 2.25em for the block (or there about's) and 5em for a node.

jensimmons’s picture

Title: Poll text and percentages can overlap » Prevent Poll text and percentages from overlapping
Project: Bartik » Drupal core
Version: 7.x-1.x-dev » 7.x-dev
Component: Code » Bartik theme
Priority: Normal » Minor
Status: Active » Needs review

Screenshot from #6:
Only local images are allowed.

Status: Needs review » Needs work

The last submitted patch, bartik-833158.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
StatusFileSize
new688 bytes
new168.78 KB
new167.11 KB

Needed even more than 5em. Blocks get 2.25em, nodes get three times that with 6.75em.

BEFORE:

AFTER:

dead_arm’s picture

Status: Needs review » Reviewed & tested by the community

I tested it and the patch resolves the issue.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Awesome! That looks much better. Committed to HEAD!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.