It would be nice to have an option on the setup of the button for a confirmation pop-up i.e. Yes/No...
Sometimes when using HTML button, its not clear if pressed, so can be pressed twice. Thanks.

Comments

BassistJimmyJam’s picture

Title: Ability to have Yes/No confirmation dialog » Confirmation Dialog Option
Assigned: Unassigned » BassistJimmyJam

This sounds like a good idea, I'll make sure it gets into the next beta.

zeezhao’s picture

Thanks. I look forward to this.

AdrianB’s picture

Subscribing.

BassistJimmyJam’s picture

Status: Active » Fixed

This has been committed in revision 293cf8b.

MasterChief’s picture

Category: feature » bug
Status: Fixed » Needs work

HI BassistJimmyJam!

I tried this new option it works well but i have a problem, the message appears multiple times, if i click cancel for example the message appear again, the number of repeat is between 1 and 5 times !!!!

Do you see what it's the source of this problem ?

I would happily test any patches.

BassistJimmyJam’s picture

Status: Needs work » Postponed (maintainer needs more info)

It sounds like the click event is being triggered multiple times. However, I am unable to reproduce this. Could you provide me with a link to a page that demonstrates this behavior?

MasterChief’s picture

Sadly i am on localhost so it will be difficult to show :(

I tried with multiple browsers but the problem is everywhere, the buttons field are in a view, is it possible that the problem is only when we use views ?

MasterChief’s picture

Ok i understood what is the problem, the problem is with http://drupal.org/project/pmgrowl

When i have new private messages this module open pop-ups, it seems that button field repeat the confirmation message the number of times corresponding with the numbers of pop-ups.

BassistJimmyJam’s picture

I have installed and configured the pmgrowl and privatemsg modules in an attempt to reproduce your issue. However, I am still getting only a single confirmation dialog. Could you tell me what version of the modules you have installed and how your view is configured? Also, what Rules do you have running when your button is clicked?

MasterChief’s picture

Hi BassistJimmyJam !

i have 6.x-2.x-dev pmgrowl and Privatemsg 6.x-2.x-dev, to reproduce the error it's very important to have at least 1 pop-up open to say you have a new message.

My configuration of pmgrowl is :

Operating Mode:
Individual Messages X
New Message alert

Choose the way messages should be alerted. Individual Messages mode will give you every new message that comes in. New Message alert will just give a notification that there are new messages.

Message persistence:
One time
Close manually X

If you have 5 pop-ups, the message will repeat 5 times.

BassistJimmyJam’s picture

Status: Postponed (maintainer needs more info) » Closed (works as designed)

I have confirmed that this is an issue with the pmgrowl module and have opened an issue at #1249064: Pass context with Drupal.attachBehaviors.

BassistJimmyJam’s picture

Forgot to mention in my last post, there is an issue with button_field module that is related to this. See issue #1249378: jQuery selector for click event does not include context which was recently fixed.

  • Commit 293cf8b on 6.x-1.x, 8.x-1.x by BassistJimmyJam:
    Issue #825516 by zeezhao: Added an option to show a confirmation message...