book_form_update() parameters are not correct

Good catch! Looks like both D7 and D6 docs need the @param sections removed.

This would be a good project for a novice contributor.

It looks to me as though the return value is the rendered select element for the parent page. I don't think it's worded very well in the @return. Care to fix it?

Hmmm. I can't get this patch to apply for me, although it's passing the tests. I believe there is already a @return segment in the file, and your patch isn't including it as context or -- lines?

Thanks, that looks like a better patch.

Hmmm... This is the result:

/**
 * AJAX callback to replace the book parent select options.
 *
 * This function is called when the selected book is changed. It updates the
 * cached form (either the node form or the book outline form) and returns
 * rendered output to be used to replace the select containing the possible
 * parent pages in the newly selected book.
 *
 * @return
 *   The rendered select element for the parent page.
 */
function book_form_update() {

So... the above patch is fine, as far as it goes, but maybe we can make the whole doc block better while we're at it?

Committed to CVS HEAD. Thanks.

We should port this one to Drupal 6.

The Drupal 6 version

Looks good, except there is an extra space at the end of this line:
+ * This function is called via AJAX when the selected book is changed on a node

Here's the same patch with the space removed (and removed the Eclipse stuff at the top, since I needed to do that to make it apply in my Eclipse workspace).

Committed, thanks.