Hello to all contributors. Thanks a lot for great module !

When i edit views which has been created a long time ago, i need some time to understand the purpose (goal) of that view.
Instead, if every Views Display will have a "comment region/field" we will write there some comments about that views.
See attached image to see what i mean.

An another example. I have a view which has about 10 block displays. The difference between this Displays is only the ImageCach preset used for image fields. And it is very difficult to remember where every ImageCache presset is used. So, a small field for writing comments can make "my work with views" quicker and easier.

Thanks.

CommentFileSizeAuthor
#11 816354-comment.patch2.19 KBdawehner
#9 816354-comment.patch2.18 KBdawehner
#7 comment-7.patch2.02 KBLetharion
#6 comment-5.patch2.05 KBLetharion
#4 comment-4.patch2.03 KBLetharion
#3 comment.patch1.42 KBLetharion
#1 views-comment-region.jpg65.52 KBintyms
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

intyms’s picture

intyms CreditAttribution: intyms commented
FileSize
views-comment-region.jpg65.52 KB

here is the attachment.

Letharion’s picture

Letharion CreditAttribution: Letharion commented
Category: feature » task

Feature request is useful, but no-one has stepped up. Moving to unassigned task list.

Letharion’s picture

Letharion CreditAttribution: Letharion commented
Assigned: Unassigned » Letharion
Status: Active » Needs review
FileSize
comment.patch1.42 KB

Patch to add comment field

Letharion’s picture

Letharion CreditAttribution: Letharion commented
FileSize
comment-4.patch2.03 KB

Update after dereine's feedback

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

What about 'Comment or document display' => 'Comment or document this display'?
I'm not sure whether it should be translatable. It will never be used on the page itself, so...

Letharion’s picture

Letharion CreditAttribution: Letharion commented
FileSize
comment-5.patch2.05 KB

Update after dereine's feedback

Letharion’s picture

Letharion CreditAttribution: Letharion commented
FileSize
comment-7.patch2.02 KB

Update again

Letharion’s picture

Letharion CreditAttribution: Letharion commented
Assigned: Letharion » dawehner

@dereine
Not sure what happened to this one. Merlin said to assign it to you :)

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Assigned: dawehner » Letharion
FileSize
816354-comment.patch2.18 KB

This doesn't save :)

Here is a new patch. The patch also changes the admin ui text.

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented
Status: Needs review » Needs work 
+        $form['#title'] .= t('This display\'s comments');

It's easiest on translator's to put that in double quotes so we don't have to escape the ' -- that's the only time we're actually encouraged to use " on t(). Otherwise this looks good.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review
FileSize
816354-comment.patch2.19 KB

A rerole basd on #10

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented
Status: Needs review » Fixed

Committed to all 3.x branches.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

johnv’s picture

johnv
Primary language Dutch
CreditAttribution: johnv commented

I posted this follow-up: #1377214: Move "This display's comments" to a more prominent place.