Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Any time line when this be port to drupal 7?
Comment | File | Size | Author |
---|---|---|---|
#49 | user_stats_rules.diff | 4.21 KB | jbova |
#42 | port-to-drupal-7-813600-0.patch | 11.93 KB | jbova |
#29 | Screen shot 2011-07-25 at 7.43.02 AM.png | 58.52 KB | kreynen |
Comments
Comment #1
Liam McDermott CreditAttribution: Liam McDermott commentedPlans to port to Drupal 7? Certainly! :)
Unfortunately I cannot provide a timeline unless it's for a paid project. If you need me to cost it out, drop me a line. My rate is currently €50/per hour.
I'm happy to review patches too.
Comment #2
Tebb CreditAttribution: Tebb commentedSubscribing.
Comment #3
andypostsubscribe
Comment #4
samgreco CreditAttribution: samgreco commentedSubscribe
Comment #5
Tebb CreditAttribution: Tebb commentedChanged title to display module name in Dashboard -> Your Posts.
Comment #6
danielm CreditAttribution: danielm commentedSubscribe
Comment #7
SilviaT CreditAttribution: SilviaT commentedsub
Comment #8
Shadlington CreditAttribution: Shadlington commentedSubscribing
Comment #9
OFF CreditAttribution: OFF commentedSubscribe
Comment #10
toxiclung CreditAttribution: toxiclung commented+1
Comment #11
izus CreditAttribution: izus commentedSubscribing
Comment #12
culfin CreditAttribution: culfin commentedsubscribe
Comment #13
Panic CreditAttribution: Panic commentedSubscribe
Comment #14
sbsimmons86 CreditAttribution: sbsimmons86 commentedsubscribe
Comment #15
likewhoa CreditAttribution: likewhoa commentedSubscribing
Comment #16
gomezsal CreditAttribution: gomezsal commentedSubscribing
Comment #17
patoshi CreditAttribution: patoshi commentedsubb
Comment #18
keltic CreditAttribution: keltic commentedsubscribe
Comment #19
RikiB CreditAttribution: RikiB commentedsubscribing :)
Comment #20
arsunyiu CreditAttribution: arsunyiu commentedsubscribe
Comment #21
ConradFlashback CreditAttribution: ConradFlashback commentedsub++
Comment #22
kreynen CreditAttribution: kreynen commentedI did an initial port of this module http://drupal.org/sandbox/kreynen/1222620
Comment #23
patoshi CreditAttribution: patoshi commentedThank you kreyen... tested and getting this error:
Fatal error: Call to undefined function rules_events_global_user_argument() in
Comment #24
patoshi CreditAttribution: patoshi commentedpublic_html/sites/all/modules/user_stats/user_stats.rules.inc on line 74
seems like the fucntion does not exist in rules version 7... how did u get it to work and patch in the first place if the rules didnt even have this function?
Comment #25
patoshi CreditAttribution: patoshi commentedMajor errors.. when i visit the user page..
screenshot:
http://prntscr.com/2crkr
Warning: Missing argument 3 for db_query_range(), called in /home/x/public_html/sites/all/modules/user_stats/user_stats.module on line 425 and defined in db_query_range() (line 2301 of /home/x/public_html/includes/database/database.inc).
Notice: Undefined variable: count in db_query_range() (line 2306 of /home/x/public_html/includes/database/database.inc).
Warning: Cannot modify header information - headers already sent by (output started at /home/x/public_html/includes/common.inc:2562) in drupal_send_headers() (line 1039 of /home/x/public_html/includes/bootstrap.inc).
PDOException: SQLSTATE[HY093]: Invalid parameter number: no parameters were bound: SELECT uid FROM {users} WHERE uid NOT IN (SELECT uid FROM {user_stats_values} WHERE name = :name) LIMIT 1, 0; Array ( ) in user_stats_cron() (line 425 of /home/x/public_html/sites/all/modules/user_stats/user_stats.module).
Comment #26
luckystrikerin CreditAttribution: luckystrikerin commentedsubs
Comment #27
kreynen CreditAttribution: kreynen commented@duckx
I'm not using Rules and didn't update those functions. You know how it goes... just scratching my own itch and all. The original user_stats had the rules calls wrapped in module_exists('rules'), so the function is never called if Rules isn't enabled.
That said I went ahead and commented out all the rules calls until someone has time to update those.
Comment #28
patoshi CreditAttribution: patoshi commentedwhat's a solution you might have to just at least show the post count? what would i need to do to at least get it semi working?
Comment #29
kreynen CreditAttribution: kreynen commented@duckx Really? Your support requests make me think twice about sharing code to move D7 ports forward. I never suggested this was finished, but I've already explained how I implemented it...
http://drupal.org/sandbox/kreynen/1222620
Have some respect for my time. At a minimum read what I've already written.
The version in my sandbox is going to be used in a production site in a few weeks, but with a very specific configuration. I don't have a need to update user_stats beyond this point. My goal in sharing the update in my sandbox was to save @Liam McDermott or another developer some time.
I've updated the sandbox page to be 100% clear about this.
Comment #30
patoshi CreditAttribution: patoshi commentedsorry for the confusion. i was under the impression you had it semi working without the errors. I didnt know all you did was just run it through the coder module and apply some theme fixes. good to know as ill see if i can take a stab at it since your point me in the right direction.
Comment #31
kreynen CreditAttribution: kreynen commented[kreynen bangs head against wall]
Just so someone else reading this thread is clean, we DO have a semi working version! That is what that screenshot is from and what will be used on a site that is launching next week. It does not generate errors when configure they way we have configured it, but it won't be hard to find something that doesn't work.
If you read the commit log you can see the issues we've found and fixed...
http://drupal.org/node/1222620/commits
We HAVE NOT tested everything that was in the D6 version. We're not using Rules at all on this site. @duckx enabled Rules and got an error. We "fixed" that by commenting out the references to Rules. You'll probably get errors with Views and other feature we aren't using too.
Again, this is an initial port... not a finished, stable release. If you are a developer and want to help push the D7 port forward, it will probably be more productive to post patches to http://drupal.org/sandbox/kreynen/1222620 until @Liam McDermott creates a 7.x branch in the official project.
Comment #32
patoshi CreditAttribution: patoshi commented@kreynen are you on advanced forum or just the regular forum?
Comment #33
snupy CreditAttribution: snupy commentedsubscribe
Comment #34
inolen CreditAttribution: inolen commented@kreynen thanks for the initial work!
I went ahead and got the cron function working:
also, a fix for counting comments in user_stats_post_count_update @ line ~891:
finally, a fix to user_stats_ip_address_update @ line ~959:
Sorry for not making a patch, just in a hurry but wanted to put this out there.
Comment #35
kreynen CreditAttribution: kreynen commented@duckx I am using Advanced Forum.
@inolen Committed.
http://drupalcode.org/sandbox/kreynen/1222620.git/commit/9ba6456
I'd REALLY encourage you to use git when working with a dev branch of a module... or in this case a sandbox version. If you did the original pull from git instead of the dev snapshot, you'd be able to create a patch with a single command line statement...
http://drupal.org/node/707484
Even if your host doesn't support git, you can still use it from your local machine. Instead of downloading the dev snapshot over HTTP, follow the instructions in each modules Version Control tab.
http://drupal.org/project/1222620/git-instructions
After you've downloaded the module with git, upload it to your host. Make your changes the same way you've always made them then download the changed files into the local directory. Use git diff to create a patch.
An enormous amount of effort went into migrating from CVS to Git. It only takes a few hours to master the basics and saves other developers hours trying to merge code snippets from comments back into modules.
Comment #36
pumpkinkid CreditAttribution: pumpkinkid commentedsub
Comment #37
rogical CreditAttribution: rogical commented+1 very much need in D7
Comment #38
bryancasler CreditAttribution: bryancasler commentedsubscribe
Comment #39
BeaPower CreditAttribution: BeaPower commentedsub
Comment #40
patoshi CreditAttribution: patoshi commentedim trying to do a git clone, but is it just me that i cant find the URL of the git repo? still new to git... usually there is a url to clone. thanks!
nvm i got it, but im getting this error upon install:
Fatal error: Call to undefined function rules_events_global_user_argument() in /home/xxx/public_html/dev/sites/all/modules/user_stats/user_stats.rules.inc on line 74
nvm again... =) this was just a old follow up. didnt read the other posts.. ignore this.
Comment #41
jbova CreditAttribution: jbova commentedThe latest version from git repo works great. Thanks.
Comment #42
jbova CreditAttribution: jbova commentedWell, I didn't have the latest version at first and had to fix the stats increment functions. I see that was done in the latest 7.x-1.x branch. Downloaded that branch and made some changes. COMMENT_PUBLISHED status was changed to 1 in D7, and COMMENT_UNPUBLISHED is now 0. This was to stay consistent with the node constants.
The hook_*_*_OLD functions have been removed and new hooks for nodes and comments have been added. Fixed a few db_query calls to work with D7. Fixed a missing ":" in one of the db_query params.
Comment #43
trillex CreditAttribution: trillex commentedsub
Comment #44
Babalu CreditAttribution: Babalu commentedsubscribing
Comment #45
Canadaka CreditAttribution: Canadaka commentedsubscribing
Comment #46
johnatwork CreditAttribution: johnatwork commentedsubscribed
Comment #47
thomas1977 CreditAttribution: thomas1977 commentedSubscribe. Highly needed.
Comment #48
Liam McDermott CreditAttribution: Liam McDermott commentedI'm short on time, but have just created a Drupal 7 branch and (hopefully) committed the work you wonderful people have done so far. :)
Would someone mind checking it works? Then I'll make the -dev branch available for wider testing. Thanks very much for the contributions so far!
Comment #49
jbova CreditAttribution: jbova commentedLiam,
This looks great so far. There is still one critical outstanding issue, the rules integration. This causes the module installation to fail completely and throw the error "Call to undefined function rules_events_global_user_argument".
It seems that this additional array data, which sets the active user, can be removed. I have attached a diff.
I believe the module needs to be disabled, uninstalled, and then reinstalled after making these changes for it to work.
Comment #50
Liam McDermott CreditAttribution: Liam McDermott commentedThanks, committed.
We can deal with anything else in separate issues.
Comment #51
andypostPlease roll-out 7.x-dev release? Also please add Version tag for issues
Comment #52
Liam McDermott CreditAttribution: Liam McDermott commentedIt takes a while from creating a dev release to Drupal creating the file and publishing the release. I also forgot to go and check the option to show a 7.x -dev snapshot on the project page (it was still available under All releases though).
I think the version tag also appears when the project node is automatically published by drupal.org, it's there now and I didn't have to do anything extra.
Should all be working now, though. :)