The attached patch adds a 'buffer' and a 'ratio' params to WMS layers.
Parsing of the string to number is done in JS, which I don't like, but I didn't find a good example
of doing it in the PHP side (form validation).

CommentFileSizeAuthor
#2 BufferRatioWMS_2.patch1.73 KBstrk
BufferRatioWMS.patch2.49 KBstrk
Members fund testing for the Drupal project. Drupal Association Learn more

Comments

tmcw’s picture

This has some console logs in it, and could you specify the radix (add a second parameter of 10) to the parseInt function?

strk’s picture

FileSize
1.73 KB

In the new patch firebug calls removed and radix added

tmcw’s picture

Status: Active » Fixed

Committed in http://drupal.org/cvs?commit=372484

Thanks for all of the work with WMS layers!

strk’s picture

Not sure which commit broke it (if this or singleTile one) but anyway current branch misses a comma by the end of line 77 of wms.inc

tmcw’s picture

Good catch, fixed. I basically applied the patches in opposite order to how you wrote them, I'd guess, so this one went above when it would have gone below and wouldn't have needed a comma? Maybe? Anyway, just committed a comma.

strk’s picture

Yes, indeed git found the code in HEAD with those behaviours order swapped

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.