New patch for proper unit-usage in core.
Here is what the patch does:
- it makes use of drupal api's to display the part of the url in front of path textfields (path.module/system.module);
- it gives us consistent textfield sizes between upload/user module for specifying resolutions and file sizes;
- have user.module make use of the '#field_(prefix|suffix)' where needed;
- did some small part of more consistent code markup for the appropriatary functions;

Please review and apply...

CommentFileSizeAuthor
#1 example.png216.23 KBStefan Nagtegaal
unit-usage-for-forms_2.diff10.01 KBStefan Nagtegaal
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Stefan Nagtegaal’s picture

Stefan Nagtegaal CreditAttribution: Stefan Nagtegaal commented
FileSize
example.png216.23 KB

Here is some screenshot which shows the difference with this patch applied.
Drupal now *could* show the base_url in front of the path specification field, using the '#field_prefix'..

Much better IMO..

thoughts? reviews?

AjK’s picture

AjK CreditAttribution: AjK commented
Category: bug » feature

Nice idea but doesn't seem to be a "bug" more a feature request.

Re-categorising.

regards,
--AjK

flk’s picture

flk CreditAttribution: flk commented

i would have to agree with ajk, this is more inline with a feature request than a bug. just my 2cents

Stefan Nagtegaal’s picture

Stefan Nagtegaal CreditAttribution: Stefan Nagtegaal commented
Category: feature » bug
Status: Needs review » Reviewed & tested by the community

Since the $form['prefix'] and $form['suffix'] i in core now, this is a bug report because we do not use them like we should..

Though I have to admit that it stinks a little to get a new feature in, but let our core committers decide on that. ;-)

Dries’s picture

Dries CreditAttribution: Dries commented

I looks uglier to me, but it might be easier to use. Not sure.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Status: Reviewed & tested by the community » Needs work

Committed everything except the user.module part which no longer applied and should probably have been posted separately anyway.

ricabrantes’s picture

ricabrantes CreditAttribution: ricabrantes commented
Version: x.y.z » 5.x-dev
Status: Needs work » Fixed

4.x is no longer supported.. This bug are fixed in D5.x-dev

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.