CVS edit link for Shellingfox

I want to contrib a module

My module is a text filter. It's will add textile markup language for Drupal system.

CommentFileSizeAuthor
#1 textile.tar_.gz10.27 KBShellingfox

Comments

Shellingfox’s picture

Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new10.27 KB

This is my module. I was write it for Drupal 7.

avpaderno’s picture

Status: Needs review » Needs work
Issue tags: +Module review

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.

As per http://drupal.org/cvs-application/requirements, the motivation message should be expanded to contain more details about the features of the proposed module/theme; for modules it should include also a comparison with the existing solutions, while for themes a screenshot is also required. As far, there is already a module with the same purpose: http://drupal.org/project/textile.

Shellingfox’s picture

A, i'm sorry.

I'll fork this project because i want to add support for Drupal 7.

avpaderno’s picture

As reported in the requirements page, the proposed project must not duplicate the work done in an existing project, which what you would do creating a version for Drupal 7 of an existing project. What would happen if the existing project would be ported to Drupal 7? The proposed module would be a duplicate of the existing one.
Then, there are many projects that don't have a version for Drupal 7; I would not create a version for Drupal 7 of IMCE just because it has not already a version for Drupal 7.

Shellingfox’s picture

Sure. And i want to be a maintainers for Textile. How can i do that?

avpaderno’s picture

Open a support request for Textile, offering to become co-maintainer of the module. If the current maintainer accepts your offer, then you will be made co-maintainer of the project.

Shellingfox’s picture

I has been create a support request here: http://drupal.org/node/812576 but i'm not sure the creator of this module will checked because the last commit was 2 years ago.

What should i do next?

erutan’s picture

Thanks for bringing textile to drupal7 - I sent an @reply to the original owner on twitter (outlandishjosh) about your request to be co-maintainer.

One bug I've noticed so far is that the last li in a ul gets put in a new ul, which is apparently a common issue with php5 and textile 2.0. While I haven't authoritatively tested it, using this as classTextile.php seems to fix the bug and hasn't introduced any more: http://github.com/taat/textile/raw/master/library/Vendor/Textile.php

joshk’s picture

Hollllllllla!

I'll get right on this. :)

avpaderno’s picture

Status: Needs work » Fixed

As joshk already replied in the support request about co-maintainership, I am marking this report as fixed.

Thank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

avpaderno’s picture

@Shellingfox: What I meant in the previous comment is that you have been added as co-maintainer of the module.

Shellingfox’s picture

Status: Fixed » Closed (fixed)

Thanks. I'll work with the module now.

avpaderno’s picture

Status: Closed (fixed) » Fixed

Status: Fixed » Closed (fixed)
Issue tags: -Module review

Automatically closed -- issue fixed for 2 weeks with no activity.

avpaderno’s picture

Component: Miscellaneous » co-maintainer application
Issue summary: View changes