CVS edit link for Spleshka

I would like to show you some themes I did. I hope you'll find them nice and useful
CommentFileSizeAuthor
#14 IMbug.zip157.9 KBspleshka
#12 IMbug.zip157.9 KBspleshka
#7 screenshot.png142.44 KBspleshka
#1 IMbug.zip147.06 KBspleshka

Comments

spleshka’s picture

Assigned: Unassigned » spleshka
Status: Needs work » Postponed (maintainer needs more info)
Issue tags: -Theme review
StatusFileSize
new147.06 KB

That was almost first theme i did. But i think it has nice interface and it pleasent to work with. My theme has beautiful blue primary menu that aligned to the top of page and it duplicates at the bottom. Also it containes a lot of regions for comfortable adding blocks wherever you want. More over, here you can find logo and sitename.
This theme made for http://bug.by

andypost’s picture

Assigned: Unassigned » spleshka
Status: Postponed (maintainer needs more info) » Needs review

Please provide a link to site with this theme installed

spleshka’s picture

avpaderno’s picture

Assigned: spleshka » Unassigned
Status: Needs review » Needs work
Issue tags: +Theme review

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.

As per http://drupal.org/cvs-application/requirements, the motivation message should be expanded to contain more details about the features of the proposed module/theme; for modules it should include also a comparison with the existing solutions, while for themes a screenshot is also required.

spleshka’s picture

I made a screenshot for this theme - it's inside an archive. Or you mean I have to make another screenshot, more common? For example, from site with this theme ?

avpaderno’s picture

Assigned: spleshka » Unassigned
Status: Postponed (maintainer needs more info) » Needs work
Issue tags: +Theme review

I mean a screenshot attached to a comment here, and possibly showing the screenshot of a site using the theme.

spleshka’s picture

StatusFileSize
new142.44 KB

Here is screenshot from site that using this theme

avpaderno’s picture

Status: Needs work » Needs review
tlattimore’s picture

Status: Needs review » Needs work

When I try demo the theme on my local Drupal install I cannot enable the theme, I get the generic error message "This version is incompatible with the 6.16 version of Drupal core."

What version of Drupal core is this theme intended for?

avpaderno’s picture

Assigned: Unassigned » avpaderno
  1.       <h3><?php print $title 

    ?>

    All those lines should be written as

          <h3><?php print $title; 

    ?>

  2. The .info file is for Drupal 6, but it misses an important information, which is the cause of the error reported by tlattimore.
  3. In ie.css, the selector used are CSS3; is there a good reason to use them, considering that IE is probably not able to handle them?
avpaderno’s picture

Status: Needs work » Closed (won't fix)

There have not been replies in the past week. I am marking this application as won't fix.

spleshka’s picture

Status: Closed (won't fix) » Needs review
StatusFileSize
new157.9 KB

Excuse me, I had a long holidays. I have fixed a template and I hope that now in it there are no errors. Check up, please. A template atteched

avpaderno’s picture

Status: Needs review » Fixed

The ID, or class of a tag is not written between apices; the theme would not probably pass an HTML validation.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

spleshka’s picture

StatusFileSize
new157.9 KB

Oh, you right. I found that mistake and fixed it. Thanks. So, what i have to do next ?

avpaderno’s picture

Your account has been approved; what you need to do next is to create your project. :-)

andypost’s picture

@kiamlaluno, please remove erroneous folder contributions/themes/IMbug

EDIT: The right one is contributions/themes/imbug where theme is stored

Status: Fixed » Closed (fixed)
Issue tags: -Theme review

Automatically closed -- issue fixed for 2 weeks with no activity.

avpaderno’s picture

Component: Miscellaneous » new project application
Issue summary: View changes