Closed (fixed)
Project:
Drupal.org CVS applications
Component:
co-maintainer application
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
14 May 2010 at 16:39 UTC
Updated:
3 Nov 2018 at 18:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
kurkuma commentedComment #2
avpadernoHello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.
As per http://drupal.org/cvs-application/requirements, the motivation message should be expanded to contain more details about the features of the proposed module/theme; for modules it should include also a comparison with the existing solutions, while for themes a screenshot is also required.
Comment #3
kurkuma commentedI would change my motivation message using the edit link provided (http://drupal.org/user/18042/edit/cvs) but I have an "access denied" response. May I add the extra information as a comment?
Comment #4
avpadernoYes, you may; it's the only way you have, as http://drupal.org/user/18042/edit/cvs is accessible only to whom has the right role, and even those users would not be able to change the motivation message from there.
Comment #5
kurkuma commentedNode access by terms in profile.
Another module to control access to nodes, but this one doesn't depend on roles being assigned to users. This is the main difference with any other access control module available: the interdependence of the roles system. Only view access is affected.
The module sets some node grants based on the terms and vocabularies assigned to the node, as well as a general grant for the author of the node (this grant is independent from the taxonomy terms, just to guarantee view access to the node's author). The view access to a node will be granted if user and node share the same term of the same vocabulary (the user's term will be from his/her profile, using the content_profile module). If the assignment of the term to the user is controlled by an administrator, this would be an easy and flexible way to control access to nodes without cluttering the roles table/interface.
From the administration interface the following settings can be selected: content types affected (many), vocabularies used as access control (many, but only the ones assigned to profile types), profile content type (only one at a time), debugging display.
There are dependencies with content_profile and taxonomy modules.
There is integration with devel module, for the node_access messages, and basic debugging messages during node display.
To do: install.txt, readme.txt, spanish translation, some re-factoring and cleaning of the code to make it compatible with any type of taxonomy and any taxonomy structure (already in work) and may be more than one profile type with some ajax magic.
Comment #6
avpadernoThanks for the reply.
Comment #7
kurkuma commentedI will recuperate and maintain the module forminspect.
I have asked its actual maintainer and we are waiting for my CVS account to be approved.
Comment #8
avpadernoPlease provide the link to the support request you opened.
Comment #9
kurkuma commentedI asked by email. But now I have created an issue for that: http://drupal.org/node/812816.
Comment #10
avpadernoThen, we are ready to go!
Thank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.
Comment #13
avpaderno