CVS edit link for nicomat

We at the Maths and Computer Science Department of the University of Antwerp use Drupal for somewhat more than a year now, and are generally very happy with it. The official university webpages use a proprietary CMS which we find is in many way inferior to Drupal. Particularly, it is based on a tabular design.

For some of our pages, it is desirable to stick to the corportate webpage design, so we created a matching Drupal theme which has served us well so far.

Finally, to return something to the Drupal community, we removed the trademarked logos from the theme and include favicon and logo as necessary by Drupal themes' "logo" and "shortcut icon" options, and plan to publish the vanilla theme on drupal.org.

The codebase can be accessed at http://win.ua.ac.be/~nschloe/other/websvn/listing.php?repname=Drupal+UA+... trunk/waves.info should give a good overview of the capabilities of the theme.
An example page runs on http://twna.ua.ac.be/.

CommentFileSizeAuthor
#10 waves.tgz15.62 KBnschloe
#9 waves.zip21.85 KBavpaderno
#8 799084_screenshot.png54.89 KBtlattimore
#1 waves.tgz16 KBnschloe

Comments

nschloe’s picture

StatusFileSize
new16 KB
avpaderno’s picture

Status: Postponed (maintainer needs more info) » Needs work
Issue tags: +Theme review

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.

As per http://drupal.org/cvs-application/requirements, the motivation message should be expanded to contain more details about the features of the proposed module/theme, and it should include also a comparison with the existing solutions. You should then add a screenshot of the theme.

nschloe’s picture

I'm not sure if I understand this correctly:

  • When I think about "features" of the theme, the only thing I could come up with is what is more technically listed in the .info file, and it's certainly not the goal of this exercise to repeat that. Right? Or is the text to be used in a context other than review?
  • I also don't understand "comparison with existing solutions" so well. I mean, it's a whole new theme! Motivation: "This theme wasn't in there before"?
  • Concerning the screenshot: As usual there's one screen shot provided with the package, plus also I linked a demo page to the original application. Ain't that what you need?
avpaderno’s picture

I could come up with is what is more technically listed in the .info file, and it's certainly not the goal of this exercise to repeat that. Right?

Concerning the screenshot: As usual there's one screen shot provided with the package, plus also I linked a demo page to the original application. Ain't that what you need?

The purpose of the requested information is to verify the application before to check the content of the archive attached here. In the case of a module, it would be probably possible to make a comparison with existing modules by reading all the code, and looking for a module with similar purpose.

nschloe’s picture

I perfectly understand the need of this for modules to avoid duplication, but *themes*?
Okay well, I'll add a sentence or two about the features of the theme and will post it here.

nschloe’s picture

Status: Needs work » Needs review

I can't seem to edit the original page, so here's the second draft:

============================== *snip* ==============================
We at the Maths and Computer Science Department of the University of Antwerp use Drupal for somewhat more than a year now, and are generally very happy with it. The official university web pages use a proprietary CMS which we find is in many way inferior to Drupal. Particularly, it is based on a tabular design.

For some of our pages, it is desirable to stick to the corporate web page design, so we created a matching Drupal theme which has served us well so far.

Finally, to return something to the Drupal community, we removed the trademarked logos from the theme and include favicon and logo as necessary by Drupal themes' "logo" and "shortcut icon" options, and plan to publish the vanilla theme on drupal.org.

We're basically looking at a three-columns layout here with a static wave-like page header here. Header and content region are separated by a purple strip which hosts the primary links if set. It also supports display of page name and slogan, primary links, secondary links, and the display of a logo at the top left.
An example page runs on http://twna.ua.ac.be/.

The codebase can be accessed at the WebSVN interface.

trunk/waves.info should give a detailed overview of the capabilities of the theme.
============================== *snap* ==============================

Cheers,
Nico

nschloe’s picture

I understand that drupal is notoriously "understaffed", so it might not be unusual to wait more than a month for a CVS account. -- Right?

tlattimore’s picture

StatusFileSize
new54.89 KB

Hello nicomat, thanks for applying for CVS access. I am trying to review your submitted theme, but I can't seem to get it to extract properly. When the .tgz file is extracted, I just get an empty folder with a ".tgz.OUT" file. See screenshot.

Could you resubmit a another version of your theme, maybe in a .tar?

avpaderno’s picture

StatusFileSize
new21.85 KB

I didn't have any problems to extract the archive.
I am attaching here a .zip archive, hoping it could be useful for tlattimore.

nschloe’s picture

StatusFileSize
new15.62 KB

Whoops! The original file is BZIP2 zipped; find a proper gzip file attached, although kiamlaluno's version should be alright as well.

nschloe’s picture

Aaaand another for weeks since the last reply here. Hmmm.. Is that b/c of the summer holidays?
I really just want to contribute my code here.

michelle’s picture

Status: Needs review » Fixed

Yell at me if you want but Drupal needs to attract more themers and keeping them sitting in a queue for 3 months isn't the way to do it. Approved.

Michelle

jensimmons’s picture

the motivation message should be expanded to contain more details about the features of the proposed module/theme, and it should include also a comparison with the existing solutions.

This: http://drupal.org/cvs-application/requirements is a terrible document for how-to-contribute themes.

Your new project must not duplicate the work done in existing projects.

??????

Yeah, that's what we want to do, scare off people wanting to contribute themes by asking them to survey all other existing themes, and write up a technical description defending why their theme is unique.

This is an example of epic fail.

Thanks nicomat for sticking around! We are just trying to figure out how to best adapt a process created for module development to the theme & design world. We aren't there yet :P, but we are getting better... your critique of the process in comment #3 and #5 will help us do that. So thanks.

And props to Michelle for finding this issue and fixing it.

michelle’s picture

I can't claim any props... I just caught his plea for help on IRC. This whole system is just such a mess. :(

Michelle

avpaderno’s picture

So far, no proposed theme has been rejected because it was duplicating the work done in other themes.
Probably, somebody who would propose a theme that is a slightly modified version of Garland would see his / her application rejected; the requirement doesn't report the degree of the duplicated work that is acceptable because that depends from the project type.

Status: Fixed » Closed (fixed)
Issue tags: -Theme review

Automatically closed -- issue fixed for 2 weeks with no activity.

avpaderno’s picture

Component: Miscellaneous » new project application
Issue summary: View changes