If I set a Flash version in 'Default settings for embedding' and my chosen Flash player, for example JW Player, has a *lower* required Flash version, the default setting is overridden with this lower value. I believe it should only be overwritten if the required version for the player is higher. For example, I need a default Flash version of 9.0.115 for H.264 videos but it is overwritten with version 7 when I use JW Player. I propose lines 514-517 of swftools.module is changed to:

// If the player requires a specific minimum flash version then assign it to the params
  if (isset($resolved_methods->player['version']) && ($resolved_methods->player['version'] > $vars->params['version'])) {
    $vars->params['version'] = $resolved_methods->player['version'];
  }

Comments

Stuart Greenfield’s picture

Version: 6.x-2.5 » 6.x-3.x-dev
Status: Active » Needs review

Discovered that 6.x-3.x wasn't actually setting the version anywhere!

Fixed on DRUPAL-6--3 with a variant of the code above - player version will only over-ride user version if the player version is higher.