it looks like the following commit:

http://drupal.org/cvs?commit=364120

was a mistake, committing some code for simpletest that is php5 only to D6.

please roll it back.

CommentFileSizeAuthor
#1 rollback.patch16.01 KBAnonymous (not verified)

Comments

Anonymous’s picture

Anonymous (not verified) commented
Assigned: Unassigned »
Status: Active » Needs review
StatusFileSize
new rollback.patch16.01 KB

rollback patch attach.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Oh hah. That's really funny. I can't take the blame for this one.

Aw man, I really wanted this in! Now I wouldn't ever have to patch core again for simpletest. It's not like we really care about PHP4 anyway. Can we just forget PHP4 even exists? :D

Anonymous’s picture

Anonymous (not verified) commented

dropping support for php4 in D6 is totally ok with me, but i guess we'd need a better process than an accidental commit ;-)

gerhard killesreiter’s picture

gerhard killesreiter commented
Status: Needs review » Reviewed & tested by the community

This certainly needs to be reverted.

I am not sure it warrants an emergency commit on my part, though.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Sorry about that -- accident! Rolled back.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

BTW that patch was originally from #582942: Add latest SimpleTest backport directly to core.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.