Latitude/Longitude filters should be float, not numeric. [#790826]

Comment	File	Size	Author
#5	790826-views_handler.patch	702 bytes	lotyrin
#4	790826-views_handler.patch	702 bytes	lotyrin

Comment #1

hutch commented 5 May 2010 at 21:49

Interesting, can you provide examples?

Log in or register to post comments

Comment #2

lotyrin commented 7 May 2010 at 03:37

I'm using the extents from a GMap to filter a view that I have below the map in an Iframe (so that only pins showing on the map will have related data shown in the iframed view).

When the user is zoomed in too far, the extent of their currently viewed map will be less than a degree wide or tall, so, with truncated ints, that means they'll have no results in the iframe. Additionally, even when zoomed out, map pins near the edges of the map were getting truncated.

I think it would be fairly common to need sub-degree accuracy for any number of other reasons.

Log in or register to post comments

Comment #3

hutch commented 7 May 2010 at 09:11

What I mean is where did you alter code to achieve this? I don't see lats and lons as int anywhere, for instance in

location_views_handler_filter_proximity.inc

a snip of SQL from the above handler in Views

(location.latitude > 52.3579618789 AND location.latitude < 52.5380050593 AND location.longitude > -3.68825012953 AND location.longitude < -3.39284604281)

Locations are stored with 6 decimal places, that's roughly 10 centimeters or 4 inches
The SQL here is using accuracy of 1/100 mm
That's a lot more accurate than the resolution of google maps which I would estimate as between 1 and 5 meters at full zoom.

Log in or register to post comments

Comment #4

lotyrin commented 7 May 2010 at 09:24

Status:

Active

» Needs review

Status	File	Size
new	790826-views_handler.patch	702 bytes

I'm not using the proximity filter, but rather separate filters for latitude and longitude.

I've prepared a patch of my changes.

Log in or register to post comments

Comment #5

lotyrin commented 7 May 2010 at 09:36

Status	File	Size
new	790826-views_handler.patch	702 bytes

My last file upload seems to be broken? (links to "http://drupal.org/files/issues") trying again.

Log in or register to post comments

Comment #6

hutch commented 7 May 2010 at 10:12

Category:	feature	» bug
Issue tags:		+bug fix

Yes, you are quite right, these fields should be float. The SQL generated in views_handler_filter_numeric.inc uses %d, we need %f here, views_handler_filter_float.inc provides that.

Changing this to bug report

Log in or register to post comments

Comment #7

hutch commented 30 May 2010 at 19:15

I would like to remind the maintainers of this patch in #5, it makes sense programatically, lat/lon should be of type float. If anyone is in a position to test this please do!