I've found that on my site, Scripture Filter doesn't interpret a range over multiple verses correctly. For example, halfway down the page of http://brisbanemarthoma.org/lectionary/march, Scripture Filter creates a link for Hebrews 5:12-6:20 to Hebrews 5:12-6 (it doesn't pick up the second colon).
I've run the verse_regex through a online testing tool, and it seems to pick up the verses correctly. It just doesn't do so when running the module.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | Multiple_Colons-776318-4-D7.patch | 588 bytes | jamesoakley |
| #4 | Multiple_Colons-776318-4-D6.patch | 571 bytes | jamesoakley |
| #3 | Multiple_Colons-776318-3-D6.patch | 559 bytes | jamesoakley |
| #3 | Multiple_Colons-776318-3-D7.patch | 576 bytes | jamesoakley |
Comments
Comment #1
thesuperav commentedSorry, link is http://brisbanemarthoma.org/lectionary/2010/march
Comment #2
jamesoakleyI have reproduced this. Changing version to 7.x, and changed the title to clarify the issue
Comment #3
jamesoakleyIs it as simple as this? If someone could check it this can be committed faster.
Comment #4
jamesoakleyIn the end I decided that the patches in #3 created too many false positives. Colon characters aren't punctuation in the same way that a comma or an ampersand are; they specifically separate chapters from verses. So a better approach is to amend the existing code and say that whenever you could have a verse number, it could also be "chapter:verse".
Committed the attached two patches.
Comment #5
jamesoakleyComment #7
vrajak@gmail.com commentedSince no one commented after the patch, I just wanted to say the D6 patch worked for me, and now my site happily reads multiple verse ranges. Thanks!
Comment #8
jamesoakleyThanks Vraja - always nice when people stop by to say thanks!