Mollom calls the same db query repeatedly

The query comes from the code to add the 'report to Mollom' links in mollom_link(). We should add some caching to either mollom_get_mode() or mollom_load_form() so that this does not need to be loaded on every, single call to mollom_get_mode().

Patch to statically cache mollom_get_mode(). Helped reduce the number of queries just to the number of unique node types on a node display.

Does not apply to D7 since we do not have mollom_get_mode() or use links in that verison.

Basically, this static caching rather belongs into mollom_form_load(). But for now, I'd move forward with this patch here, because entire loading/caching will need to get changed via #717874: Provide exportables for Mollom forms

Does that mean we should add a todo?

I don't think so... the exportables issue is enough of a todo. Not sure about CTools/Features' status for D7, but ideally, exportables support should only be added there.

Anyone want to mark as RTBC then? :)

+++ mollom.module	18 Apr 2010 21:51:52 -0000
@@ -678,8 +678,14 @@ function mollom_delete_form_list($reset 
+  if (!isset($modes[$form_id])) {
+    $mollom_form = mollom_form_load($form_id);
+    $modes[$form_id] = isset($mollom_form['mode']) ? $mollom_form['mode'] : MOLLOM_MODE_DISABLED;
+  }

1. Minor: mollom_form_load() is documented to be a menu loader but it is obviously used in different contexts too.
2. Minor: wouldn't it be nicer if $mollom_form['mode] defaulted to MOLLOM_MODE_DISABLED so we can avoid the isset()? We already prepare a default $mollom_form in mollom_form_load(), it seems. See the following snippet taken from mollom_form_load():
   

       // Ensure default values (partially for administrative configuration).
       $mollom_form += array(
         'form_id' => $form_id,
         'title' => $form_id,
         'elements' => array(),
       );
   

   I haven't tested it but it seems like we might be able to add a 'mode' => MOLLOM_MODE_DISABLED.

I think the problem with adding a default in mollom_form_load() is that function could return FALSE if the form_id is not provided by any hook_mollom_form_info(). Therefore we would still have to check if $mollom_form is FALSE in mollom_get_mode().\

Plus, that default value is actually loaded in mollom_form_info().

Committed #3 to DRUPAL-6--1.
http://drupal.org/cvs?commit=363636

Actually, this needs to be ported to CVS HEAD (Drupal 7) before it can be marked 'fixed'. Let's try to keep CVS HEAD in sync.

The mollom_get_mode() function isn't in the D7 branch since we don't add the 'Report to Mollom' links. :)