Closed (fixed)
Project:
Drupal.org CVS applications
Component:
new project application
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
18 Apr 2010 at 07:24 UTC
Updated:
3 Nov 2018 at 18:05 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
shushu commentedFirst version/draft for domain_rules.
Currently only creation of a domain exists (and works properly).
Use case - create a domain when a user creates a node.
While domain_user only create user-specific domains, which is limited, this module is flexible using rules+tokens.
Comment #2
avpadernoHello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.
As per http://drupal.org/cvs-application/requirements, the motivation message should be expanded to contain more details about the features of the proposed module, and it should include also a comparison with the existing solutions.
Comment #3
mitchell commentedI can vouch for his code. Looks great!
You can see my gratitude in #423800-4: Provide example foreign UI.
Best of luck, shushu.
Comment #4
shushu commentedHello,
Hope to get the approval this time...
Attached a new version of my new module - domain_rules.tgz.
The motivation for this module is to add the following Rules actions:
Combining all of those actions together makes a much stronger capabilities than existing automatic domain creation such as domain_user module.
Hope this clears the motivation, and hope my code is good enough for the CVS.
Comments are more than welcome.
Comment #5
shushu commentedAny news ?
How can I get a working cvs account ?
Almost a month from my first submittion.
Regards,
Shushu
Comment #6
Exploratus commentedWould love to know the status...
Comment #7
mitchell commentedI have reviewed the submitted code. This application can be approved.
Updating status according to cvs application workflow.
Comment #8
avpadernoThere is a Drupal function to use, in such cases.
Comment #9
shushu commentedThanks for the detailed feedback.
5. I suggested it for domain.module, and was answered "The 6.x branch is closed to new features. " #782838: Document: "Add default roles dynamically" to dynamically add new subdomains. Still, I think many will appreciate those features, and since I plan to find time to maintain it, I see no reason why not to publish it.
4. TODO notes were for myself. All been removed.
3-1. Done, thanks.
I also used the Coder module, which was very useful to pinpoint the issues.
Please approve my account so I will be able to publish it.
Regards,
Shushu
Comment #10
avpadernoCheck the indentation character, as some files don't use the two spaces as suggested in the coding standards.
Thank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.
Comment #13
avpaderno