Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Right now, when you switch themes from Bluemarine, nothing actually appears to happen. I spent about 30 seconds clicking around before I realized that the new theme _was_ in fact being applied, but only to non-admin pages.
"System default" should always be the setting unless something else was specifically put in to eliminate this confusion.
| Comment | File | Size | Author |
|---|---|---|---|
| #20 | patch_42.txt | 1.2 KB | webernet |
| #18 | themes.patch | 1.18 KB | yched |
| #16 | admin_theme_default.patch.txt | 2.49 KB | davemicc |
| #15 | admin_theme_default_3.patch | 2.45 KB | edmund.kwok |
| #14 | admin_theme_default_2.patch | 2.49 KB | webchick |
Comments
Comment #1
webchickHere's a patch.
Comment #2
dries commentedI was confused by this too. Why don't we remove the 'system default' option and just go with the theme names?
Comment #3
webchickBecause the theme names are what cause this problem. :)
By default, that would make the variable "bluemarine" which means the admin theme stays "bluemarine" until you deliberately switch it to "chameleon" or whatever. Then if you switch your theme again (say you're trying out 10 different themes to see what they look like), you have to go back _again_ and switch it to "Theme X."
"System default" makes the admin theme and the "normal" theme match. If you want to override this and make the admin theme always bluemarine, then you can also do that, but this way the default behaviour remains the same.
Comment #4
webchickGrrr.
I hate to bump my own issue, but this just wasted another 5 minutes of my life because I forgot this wasn't fixed and
couldn't figure out my bloody theme wouldn't change from bluemarine.
Please can we get this fixed?? Pretty please? ;)
Comment #5
edmund.kwok commented+1 on the suggestion.
Reduces confusion if users don't go thru all the administrative settings.
I was porting a theme to Drupal for the first time and changed the site theme to the new one. Nothing happened and I checked all the files and everything required was there. When I logout, only then the theme appear and I realized that the administrator theme was set to bluemarine by default.
When default value of admin_theme is set to 0 (integer), pushbutton is selected by default. Changed this by setting '0' as a string and 'System default' is selected by default. Patch works on HEAD.
Code still needs review...
Comment #6
Robrecht Jacques commentedI think it makes sense to have admin_theme == system default instead of bluemarine. The (rerolled) patch does that.
On the other hand, would one of the following options also not limit confusion:
- display a message on admin/build/themes when changing the default theme *and* the admin theme is set,
- or, disable the admin theme for admin/build/themes?
Personally, i think that webchicks solution + a message (only if admin_theme != system default) would be best.
Comment #7
edmund.kwok commentedPerhaps a message like this?
Comment #8
edmund.kwok commentedFixed the incorrect link to the administration theme page and the message formatting.
Comment #9
webchickCool. I like that change a lot. Three small changes in this patch:
1. Rolled the patch from Drupal root, rather than in the system directory, per standards.
2. Instead of hard-coding the <em> tags around the administrative theme name, I instead used the %admin_theme placeholder, which places the output in a theme('placeholder').
3. I also added a sentence to further explain that the theme actually did apply, so the message now reads:
Comment #10
webchickEr. one sec. that didn't work. ;)
Comment #11
webchickOk, let's try that again. :)
Same patch, but changed the last sentece to...
Since users may override the default theme setting if they're given permission.
Comment #12
webchickHm. No idea where that weird alert() stuff came in on checkboxes. Must've been some debugging from a previous patch.
Comment #13
webernet commentedPerhaps a minor change to the wording:
Please note that the <a href="!admin_theme_page">administration theme</a> is still set to the %admin_theme theme, consequently, the theme on this page remains unchanged. All non-administrative sections of the site, however, will show the selected %selected_theme theme by default.The changes in this patch should help make changing themes less confusing.
Comment #14
webchickWorks for me. That message is getting a little verbose now, but on the other hand it is terribly confusing without it. ;P
Also, I added a semi-colon before consequently, rather than a comma. I like semi-colons. ;)
Comment #15
edmund.kwok commentedPatch rerolled against HEAD.
Yup, the message makes things clearer now :-). Hmm, will this be commited?
Comment #16
davemicc commentedPatch rerolled against HEAD.
I was also confused at first when I changed the theme and the admin pages didn't change. This patch handles things as I would expect.
Comment #17
Steven commentedGood patch, this will reduce a lot of confusion. Committed to 5.
Comment #18
yched commentedSmall correction :
typo ($values instead of $form_values)
And small improvement :
if the "new" default theme is the same as the admin theme, no need to display the message.
Comment #19
davemicc commentedNice catch. I missed that while testing because the sentence still makes sense without the selected theme name in there. This patch works for me.
Comment #20
webernet commentedRerolled.
Looks good to me - Fixes a typo and eliminates a potentially confusing message if the "Administration theme" is the same as the new "Default theme".
Comment #21
yched commentedRTBC, then...
Comment #22
drummCommitted to HEAD.
Comment #23
(not verified) commented