This is a patch for 6.x-1.11 to fix common issues [#772668]

First thank you @kiamlaluno for working so hard on this module!

This is a patch to apply to 6.x-1.11 to fix common issues making the listed release version more usable. If you are using any of the 6.x-1.12 betas or dev versions this will not work for you.

I've been digging in the issue queue a *lot* over the past week and I keep seeing the same problems posted over and over again so I'm contributing back a patch that fixes the most common problems I've run into. This is primarily the taxonomy tags not saving/displaying and the "other" pages tags not saving/displaying properly. These fixes come from my own trial and error and diligently searching this issue queue. I will not take credit as others have done most of the work and/or found identical solutions. Consider this just a compilation of other patches.

Please backup your DB before trying this. Ideally though this is for people wishing to do a fresh install of nodewords but it may work with existing tags if your version is close to the 6.x-1.11 version. I can only say it works for me and I didn't loose any existing tags. If you are rolling back you still need to run update.php to clean up the schema.

This patch is to be applied to the 6.x-1.11 stable release, it will not work with the dev versions or any of the 6.x-1.12 betas. Please use a clean unpatched 6.x-1.11 version as your base, http://drupal.org/node/671570

If you were already using a dev version dated prior to 2010/02/23 you should be able to clear your cache, run update.php and be good to go. If your version is more recent you may not be able to save your data.

If you need info on applying the path see the handbook page, http://drupal.org/node/60108

Comment	File	Size	Author
#20	nodewords-n772668-19.patch	1.46 KB	DamienMcKenna
#19	nodewords-n672096-31.patch	1.83 KB	DamienMcKenna
#16	nodewords.module.patch	520 bytes	sebas5384
	nodewords_1.11.patch	2.27 KB	chales

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

glynster CreditAttribution: glynster commented 15 April 2010 at 22:27

Hi chales,

Perfect this has fixed the saving issues for me completely. As I with you have been trying so many solutions.
Hopefully more people can see this to help them out as well. Let's roll these updates ASAP to make a new release of 6.x-1.12. Then kiamlaluno is free without stress to focus on the new versions of the module.

Both of you great jobs.

Comment #2

lizac CreditAttribution: lizac commented 7 May 2010 at 14:30

this has also fixed my issue on custom pages meta tags. Thanks a lot!

Comment #3

juankvillegas CreditAttribution: juankvillegas commented 7 May 2010 at 15:59

Status:

Active

» Reviewed & tested by the community

I've tested it in my pages and it perfectly works. I hope this will be implemented soon in a stable version.

Comment #4

Anonymous (not verified) CreditAttribution: Anonymous commented 8 May 2010 at 04:49

Status:

Reviewed & tested by the community

» Active

The changes made from the patch are already present in the last developed code (and in the earlier code); this patch is only provided for benefit of users using version 6.x-1.11).

Comment #5

emdalton CreditAttribution: emdalton commented 13 May 2010 at 22:22

Thank you. This was a huge help. I thought I was going to have to switch to using http://drupal.org/project/inject instead. :( This patch made 6.11 work for me!

Comment #6

excell CreditAttribution: excell commented 16 May 2010 at 01:33

Does this patch also fix the "default value for the meta tag ROBOTS is not used" issue? Thanks!

Comment #7

chales CreditAttribution: chales commented 20 May 2010 at 18:37

It does not but I can look into it if you need that. I'm hoping that a newer stable release will show up soon.

Comment #8

ecsmike CreditAttribution: ecsmike commented 24 May 2010 at 15:12

Category:	support	» bug
Priority:	Minor	» Critical

I have installed 6.x.1.11 (stable release) and this patch.

The patch fixes the problem of the metatags not being saved in the database but no metatags are being rendered on any of the pages in the web site.

I have checked and rechecked the meta tags content configuration and everything appears to be correct.

Any suggestions would be welcome.

Comment #9

Anonymous (not verified) CreditAttribution: Anonymous commented 24 May 2010 at 15:24

Category:	bug	» support
Priority:	Critical	» Minor

See #669896: Meta tags content is not correctly shown.
This report has only the purpose of offering a patch for users of the version 6.x-1.11 to resolve some of the issues reported for that version; the patch could not be complete, but its purpose is not resolve all the issues reported for 6.x-1.11.

Thanks to chales for providing this patch.

Comment #10

ecsmike CreditAttribution: ecsmike commented 24 May 2010 at 17:40

Although in my situation there is absolutely NOTHING rendering in the HTML in the head section for any of the metatags selected, I went ahead and followed the instructions you referenced.

There is no change whatsoever - the metatags I define are being placed in the database but nothing is being rendered in the HTML - not even the meta name="description" or meta name="keywords" portions.

To reiterate I have followed all instructions and installed a clean copy of 6.x.1.11 and the patch as well as now following the instructions you referenced and nothing is rendered on the pages.

I really need your help to get Nodewords working in some fashion. If you have a suggestion about upgrading to some other version let me know, otherwise can you give me some more suggestions for 6.x.1.11 patched?

Thank you for responding to my earlier request.

Comment #11

3dloco CreditAttribution: 3dloco commented 27 August 2010 at 07:21

Comment #12

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 18 October 2010 at 00:51

Issue tags:

+v6.x-1.12 blocker

Tagging this. We want the next release to be rock solid, so if you have some time please help test the v6.x-1.x-dev release to see if all of the above issues are resolved.

Comment #13

chales CreditAttribution: chales commented 19 October 2010 at 14:36

It may take a couple of days but I'll try to setup an install and give it a try.

Comment #14

Dave Reid

he/him

English

Nebraska USA

CreditAttribution: Dave Reid commented 30 October 2010 at 04:59

Status:

Active

» Fixed

I double checked and all these fixes are now included in the latest code or don't matter anymore. I feel confident marking this as fixed. Please help review the latest code!

Comment #15

13 November 2010 at 05:00

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Comment #16

sebas5384 CreditAttribution: sebas5384 commented 23 March 2011 at 22:46

Status:

Closed (fixed)

» Needs review

File	Size
nodewords.module.patch	520 bytes

Still for "Other Pages" isn't working right yet, because after putting some meta description for a page like for exemple /news that is a View's Page the meta tag for description doesn't appear.
I did some debug and i find the problem, why this is happen, dont know, but with this patch works like a charm.

Cheers.

Comment #17

Dave Reid

he/him

English

Nebraska USA

CreditAttribution: Dave Reid commented 6 April 2011 at 01:44

Status:

Needs review

» Fixed

Again this does not reflect a patch against the current code. This is already fixed. If there are bugs in 6.x-1.x only please file issues and patches.

Comment #18

20 April 2011 at 01:51

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Comment #19

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna commented 26 June 2011 at 04:31

Version:	6.x-1.11	» 6.x-1.x-dev
Status:	Closed (fixed)	» Needs review

File	Size
nodewords-n672096-31.patch	1.83 KB

I've re-rolled this patch for the latest 6.x-1.x, but left the taxonomy term/vocabulary fix to another issue (#672096: Meta tags are not saved for taxomony terms or vocabularies). Thanks for your help.