Found that thickbox fails to show images in popup if URL of these images looks like:
http://domain.com/?q=system/files/imagecache/sideimage/share/informative...

Instead showing it in iFrame, thickbox tries to load it via AJAX as HTML content.

This happens in thickbox.js file - it detect images by /\.jpg$|\.jpeg$|\.png$|\.gif$|\.bmp$/ from baseURL. I propose to use regexp /\.jpg(?:$|\&)|\.jpeg(?:$|\&)|\.png(?:$|\&)|\.gif(?:$|\&)|\.bmp(?:$|\&)/ from url instead.

Patch attached.

CommentFileSizeAuthor
thickbox.js_.patch568 bytespavel.karoukin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

frjo’s picture

frjo CreditAttribution: frjo commented
Status: Needs review » Postponed

Would it not be easier to just turn on Clean URLs?

Any how, I suggest you try out the Colorbox module, http://drupal.org/project/colorbox as Thickbox replacement.

The Thickbox script is getting a bit old and I think Colorbox could be a good upgrade path. I have been made a co-maintainer of Colorbox and have ported over all of Thickbox features to it. Just released a new beta today.

pavel.karoukin’s picture

pavel.karoukin CreditAttribution: pavel.karoukin commented

In my application (it's intranet) I can't use clean urls. And I know thickbox is old, but since it still there and patch is really simple - why not do it? =)

frjo’s picture

frjo CreditAttribution: frjo commented
Status: Postponed » Closed (won't fix)
Erik Seifert’s picture

Erik Seifert CreditAttribution: Erik Seifert commented

Same problem here. Should really be fixed.