Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
hook_openid() uses the old pattern, hook_openid($op, $arg), rather than the preferred hook_openid_foo($arg). Perhaps it is better to use drupal_alter() instead. Also, the hook should take the $service array as an argument, because modules may want to inspect $service['types'] like the OpenID module itself does before adding AX to the request.
Would it make sense to also add hooks for the association request in addition to the authentication request?
Comment | File | Size | Author |
---|---|---|---|
#6 | openid-request-alter-1.patch | 9.4 KB | c960657 |
#1 | openid-request-alter-1.patch | 16.46 KB | c960657 |
Comments
Comment #1
c960657 CreditAttribution: c960657 commentedThis changes hook_openid_request($op, $request) to hook_openid_request_alter($request, $service). Also, hook_openid_response($response, $account) is now invoked for all responses received, even if there is no $account.
Comment #2
BerdirLooks like this is D8 stuff :) Will also probably not apply anymore..
Comment #3
karschsp CreditAttribution: karschsp commentedPart of meta issue #1025928: [meta] Remove the last $op params from our hooks
Comment #4
Berdir#1: openid-request-alter-1.patch queued for re-testing.
Comment #6
c960657 CreditAttribution: c960657 commentedComment #7
sunComment #8
catchLooks good. Committed/pushed to 8.x.
This will need a change notification.
Comment #9
izus CreditAttribution: izus commentedAdded a change notification http://drupal.org/node/1388118