hook_openid() uses the old pattern, hook_openid($op, $arg), rather than the preferred hook_openid_foo($arg). Perhaps it is better to use drupal_alter() instead. Also, the hook should take the $service array as an argument, because modules may want to inspect $service['types'] like the OpenID module itself does before adding AX to the request.

Would it make sense to also add hooks for the association request in addition to the authentication request?

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

c960657’s picture

Status: Active » Needs review
FileSize
16.46 KB

This changes hook_openid_request($op, $request) to hook_openid_request_alter($request, $service). Also, hook_openid_response($response, $account) is now invoked for all responses received, even if there is no $account.

Berdir’s picture

Version: 7.x-dev » 8.x-dev

Looks like this is D8 stuff :) Will also probably not apply anymore..

karschsp’s picture

Berdir’s picture

#1: openid-request-alter-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, openid-request-alter-1.patch, failed testing.

c960657’s picture

Status: Needs work » Needs review
FileSize
9.4 KB
sun’s picture

Status: Needs review » Reviewed & tested by the community
catch’s picture

Title: Convert hook_openid('request', ...) to hook_openid_request_alter() » Change notification for: Convert hook_openid('request', ...) to hook_openid_request_alter()
Priority: Normal » Critical
Status: Reviewed & tested by the community » Active

Looks good. Committed/pushed to 8.x.

This will need a change notification.

izus’s picture

Title: Change notification for: Convert hook_openid('request', ...) to hook_openid_request_alter() » Convert hook_openid('request', ...) to hook_openid_request_alter()
Priority: Critical » Normal
Status: Active » Fixed

Added a change notification http://drupal.org/node/1388118

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.