Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This is a semi-backport of the auto-hiding of modules that have hidden = TRUE in their .info files. It is confusing for end-users when there are Drupal 6 modules only used for SimpleTests but shouldn't ever be enabled. Why should they see them in the first place? We should backport this behaviour from Drupal 7.
Comment | File | Size | Author |
---|---|---|---|
#7 | 764548-hide-modules-D6.patch | 5.31 KB | Dave Reid |
#2 | 764548-hide-modules-D6.patch | 787 bytes | Dave Reid |
Comments
Comment #1
Dave ReidOriginal issue is #293223: Roll back "Hide required core modules"
Comment #2
Dave ReidComment #3
Gábor HojtsyLooks reasonable, can we have a tester or two? :)
Comment #4
sunManual testing probably means:
1) Enable, disable, uninstall, re-install some modules and ensure it works properly. Also ensure that dependencies are taken into account.
2) Comment out a
hidden = TRUE
declaration, and enable that module.3) Uncomment that declaration, and enable, disable, ... some modules. The hidden one should stay enabled.
Comment #5
Dave ReidHidden modules should not be enabled by end-users, so they should not stay enabled. I'm not sure why we'd want to test that or dependencies?
EDIT: I guess to make sure that *normal* module functionality works, so makes sense. It's been working so far for me on lots of enables and disables. Testing is also working fine.
Comment #6
Dave ReidAnyone care to RTBC? I've been using this on some client sites with no issues.
Comment #7
Dave ReidReviewing the code in D7 I actually found a bug because the hidden modules I had didn't have dependencies[] in their .info files. If I added dependencies[] = xmlsitemap to xmlsitemap_test.info, I got errors on the module page. Revamped the patch to use the code in D7's system_modules(). This should be ready for final review.
Comment #8
Damien Tournoud CreditAttribution: Damien Tournoud commentedLooks good to me from a code review perspective, but need some actual testers.
Comment #9
sunI've manually tested this patch and it seems to be working fine.
Comment #10
Gábor HojtsyThanks, committed.