See http://drupal.org/node/721436#comment-2777298 and downwards.

CommentFileSizeAuthor
#5 remove_drupal_unpack.patch6.34 KBcatch
#3 remove_drupal_unpack.patch4.99 KBcatch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jpmckinney’s picture

jpmckinney CreditAttribution: jpmckinney commented

A summary from that other issue:

The magical drupal_unpack() thing is really weird and messes up the namespace pretty badly. (I can only imagine what happens at the moment if someone tries to put something in $account->data['roles'], for example.)

Looks like drupal_unpack() is also used a couple times by comment module to "unpack" $user->data into the $comment object...

Note that $comment->data is the comment author's $user->data.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Active » Needs review
FileSize
remove_drupal_unpack.patch4.99 KB

Here's a patch which removes all calls to drupal_unpack() in core (only used for comments and users). I'm getting odd test failures locally but would like to see what the bot says.

Status: Needs review » Needs work

The last submitted patch, remove_drupal_unpack.patch, failed testing.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs work » Needs review
FileSize
remove_drupal_unpack.patch6.34 KB

Fixed contact tests, the rest must be my crufty HEAD install.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented

Oh and just to be clear, the patch doesn't actually remove drupal_unpack(), but we could if we wanted to since it's just dead code now.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs review » Reviewed & tested by the community

That's nice. Thanks for cleaning out old cruft.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks
.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.