update from Mollom 6.x-1.12 to 6.x-1.13

The update process was aborted prematurely while running update #6110 in mollom.module.

Comments

eule’s picture

Version: 6.x-1.12 » 6.x-1.13
dave reid’s picture

Status: Active » Postponed (maintainer needs more info)

Can you report what the actual error message was?

W.M.’s picture

I get same error.

An error occurred. http://mysite.com/update.php?id=34&op=do <br /> <b>Fatal error</b>: Call to undefined function _mollom_status() in <b>/home/usr/public_html/mysite/sites/all/modules/mollom/mollom.install</b> on line <b>351</b><br />

dave reid’s picture

Hmm, that shouldn't happen if the module is enabled. It's defined in mollom.module. Can either of you confirm that the Mollom module itself is enabled?

W.M.’s picture

It was off... So you say it should be on while running update.php ?!

eule’s picture

hi

i disenabled allways modules before i delete from webspace. if i have the new files on the serv i step to update.php

dave reid’s picture

Status: Postponed (maintainer needs more info) » Fixed

Ok I've confirmed the update bug since we need to call drupal_load('module', 'mollom') before the call to _mollom_status(). This is now fixed in CVS and will be available in the next release.
http://drupal.org/cvs?commit=350520
http://drupal.org/cvs?commit=350522

Didn't notice this error when testing the upgrade paths since I did have the module enabled. I will make sure to include that when I test upgrade paths in the future.

W.M.’s picture

Status: Fixed » Postponed (maintainer needs more info)

I have applied the patch to the install file and got these ok messages (I guess):

The following queries were executed
mollom module
Update #6110

    * No queries

Update #6111

    * UPDATE {mollom_form} SET enabled_fields = '%s' WHERE mode = %d

Update #6112

    * ALTER TABLE {mollom} ADD `changed` INT NOT NULL DEFAULT 0

Please confirm :)

dave reid’s picture

Status: Postponed (maintainer needs more info) » Fixed

Yes that looks correct. I also adjusted the query in 6111 to actually show the proper query, and fixed the use of an undefined constant if the module is not enabled.
http://drupal.org/cvs?commit=350618
http://drupal.org/cvs?commit=350620

W.M.’s picture

I am not sure what to do with these new patches as I have already modified the module.install file as described under #7 and ran update.php ...

Is it possible to modify the module.install file again and re-run update.php ?! Should I ?!

Thanks :)

eule’s picture

fix works ..thanks

W.M.’s picture

Is there going to be any new release with the fix ?!

Correct me if I am wrong but I think a way to bypass these patches is to first uninstall previous version of Mollom and then installing the latest one from April the 5th ?!

dave reid’s picture

It will be included in the next release but we don't have a timeline for that yet. The update will work if you have the Mollom module enabled when you run update.php, or if you download the 6.x-1.x-dev version (http://drupal.org/node/240825).

CiaW’s picture

I came by here and see that others have had the same issue I just had, I wasn't sure if it was just me or not. Here's how I made it work:

When you're at the update screen and it is at the page to select update versions, go down to Mollom and it showed 6110 which I knew wasn't right after 2 attempts including once deleting the old folder and extracting the new version; so I clicked on the drop-down and selected 6112 and then went down and clicked on update. This time the update worked!

I don't know why the version defaulted to 6110, nor why 6113 wasn't an option?; but I just selected the closest to the most recent (i.e. 6112) and thankfully that did the trick.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 82bc2ab on master, fai6, 8.x-2.x, fbajs, actions by Dave Reid:
    #762456 by Dave Reid: Fixed error in mollom_update_6110() if the module...

  • Commit 82bc2ab on master, fai6, 8.x-2.x, fbajs, actions by Dave Reid:
    #762456 by Dave Reid: Fixed error in mollom_update_6110() if the module...