CVS edit link for magicRoot

I would like to begin to participate in the drupal community by contributing my first module. I have worked with drupal for more than a year now by learning its framework and behavior. Actively participating and contributing will allow me to learn more about this great system and help me uphold the community standards in terms of development, coding, and licensing.

Before I began to develop my module, I first searched the modules list in drupal.org to see if anyone has implemented something similar; I could not find a module that performed my desired task. Hence I decided to pursue the development of the module. I also want to see how my coding ability would measure up to the inspection of the approval process. This would give me great insight as to what I need further practice on.

The module itself is pretty simple, it finds a css selector where the site name text lives(specified by a user who has administration privileges to the module) and animates different lines of text (also specified by the user) until it reaches the original site name text, which is displayed in the end. I believe I have a good working version at this point that I would like to expose to the community.

CommentFileSizeAuthor
#1 dynamic_site_name.zip6.37 KBmagicRoot

Comments

magicRoot’s picture

magicRoot commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new dynamic_site_name.zip6.37 KB
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work
Issue tags: +Module review

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.

As per http://drupal.org/cvs-application/requirements, the motivation message should be expanded to contain more details about the features of the proposed module, and it should include also a comparison with the existing solutions.

magicRoot’s picture

magicRoot commented

The modules duty is to find a css selector (given by the user with adminstrative privileges, the css selector should be the area where the site name exists) in a page and initially remove that text. After some defined time interval a sequence of texts will be displayed in the page where the css selector was given (the text displayed, the time before the text is displayed, and the time each text is displayed is also defined by the user).
Example:

css selector in the page: .site-name a

text living in this selector: My Site

text defined by the user:
This is sentence 1
This is sentence 2

time before display of texts begins: 2 seconds
time for each text to display: 2 seconds

When a page loads, the "My Site" css will be set to dispaly: none. Two seconds after the page load, the text "This is sentence 1" will appear where "My Site" should be. Two seconds later "This is sentence 2" will appear where "This is sentence 1" was. Two seconds later "My Site" will appear where "This is sentence 2" was. The text "My Site" will remain for the remainder of the page view.

I added a setting to allow this behavior to execute after each page load or only once per the lifetime of a browser window.

I have not encountered another module that does something similar to this.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno

I will review the code tomorrow.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work 
  1. /**
* 	Copyright 2010 Omar Ziranhua

    This file is part of Dynamic Site Name.

    Dynamic Site Name is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation, either version 3 of the License, or
    (at your option) any later version.

    Dynamic Site Name is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.

    You should have received a copy of the GNU General Public License
    along with Dynamic Site Name.  If not, see <http://www.gnu.org/licenses/>.
	
*/

    That comment should be removed. Modules committed in Drupal.org repository are licensed only under a single license, and not two; then there is no choice about the license to use, as it must be the same license used by Drupal.
    Crell, then, would suggest to remove Copyright 2010 Omar Ziranhua. That statement would not be anymore true, when you accept patches.

  2. Drupal variable names should not contain characters other than letters from a to z, and underscore.
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Closed (won't fix)

There have not been replies in more than a week. I am marking this report as won't fix.

magicRoot’s picture

magicRoot commented

Hi,

May I still submit this after omitting the suggested comments from the source code?

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Component: Miscellaneous » new project application
Assigned: avpaderno » Unassigned
Issue summary: View changes

Please read the following links as this is very important information about CVS applications.

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for these applications. Please read Migrating from CVS Applications to (Git) Full Project Applications and Applying for permission to opt into security advisory coverage on how this affects and benefits you and the application process. In short, every user has now the permissions necessary to create new projects, but they need to apply for opt into security advisory coverage. Without applying, the projects will have a warning on projects that says:

This project is not covered by Drupal’s security advisory policy.