I have updated the location.xx.inc files with the province data for each of the countries.

gg - Guernsey
je - Jersey
im - Isle of Man

patch against 6.x-3.x-dev (March 29 2010)

Comments

yesct’s picture

Title: Updated location.gg.inc, location.je.inc and location.im.inc » Updated location.gg.inc, location.je.inc and location.im.inc (location.xx.inc)
Issue tags: +location bdragon consider commit

adding the string location.xx.inc (so this issue will show up when searching for all the location.xx.inc issues)

also tagging.

rooby’s picture

Status: Needs review » Active

The patch didn't attach, can you post it again?

yesct’s picture

opps. I missed that!

TechnoBuddhist’s picture

StatusFileSize
new599 bytes
new405 bytes
new681 bytes

Sorry, did I forget to attach sorry!!

yesct’s picture

Status: Active » Needs review
rooby’s picture

Status: Needs review » Fixed

I'm no geographer but it looks good to me. Thanks.
Committed to 5, 6 & 7.

http://drupal.org/cvs?commit=376390
http://drupal.org/cvs?commit=376392
http://drupal.org/cvs?commit=376394

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

DanielJohnston’s picture

Although this is entirely correct it has killed off geocoding of locations in these three 'countries'. I'll try to put patches together (in a separate issue?) that copy the Google UK information from location.uk.inc to each of the includes - this may not work out perfectly as it's not something I've ever done before.

It's also a bit awkward when trying to limit Location selection to just the UK, since any organisation that covers 'just the UK' in practice covers these three as well. Not a complaint, I can see why this makes sense and my Jersey / Guernsey / Isle of Man customers will probably appreciate being treated as actual countries.

rooby’s picture

Status: Closed (fixed) » Fixed

- Setting status back to fixed so people see this post.

Yeah, maybe make a new issue and just put in a reference to this issue to say this was the cause.
Thanks for catching this.

DanielJohnston’s picture

Thanks. I've created an issue at #835174: Geocoding for Guernsey, Jersey, Isle of Man to follow up on this. As soon as I created the issue, I realised my logic was wrong on this being the cause of my problems with geocoding - it was related to patching from #326665: UK cities are in state/province field and inputting locations from the three as countries rather than UK provinces.

hutch’s picture

I'm not sure if I'm swimming in the same direction or not, but I have just posted a patch in #326665: UK cities are in state/province field #38

Status: Fixed » Closed (fixed)
Issue tags: -location bdragon consider commit

Automatically closed -- issue fixed for 2 weeks with no activity.