Closed (fixed)
Project:
Location
Version:
6.x-3.x-dev
Component:
Data update
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
30 Mar 2010 at 12:18 UTC
Updated:
3 Jan 2014 at 01:08 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
yesct commentedadding the string location.xx.inc (so this issue will show up when searching for all the location.xx.inc issues)
also tagging.
Comment #2
rooby commentedThe patch didn't attach, can you post it again?
Comment #3
yesct commentedopps. I missed that!
Comment #4
TechnoBuddhist commentedSorry, did I forget to attach sorry!!
Comment #5
yesct commentedComment #6
rooby commentedI'm no geographer but it looks good to me. Thanks.
Committed to 5, 6 & 7.
http://drupal.org/cvs?commit=376390
http://drupal.org/cvs?commit=376392
http://drupal.org/cvs?commit=376394
Comment #8
DanielJohnston commentedAlthough this is entirely correct it has killed off geocoding of locations in these three 'countries'. I'll try to put patches together (in a separate issue?) that copy the Google UK information from location.uk.inc to each of the includes - this may not work out perfectly as it's not something I've ever done before.
It's also a bit awkward when trying to limit Location selection to just the UK, since any organisation that covers 'just the UK' in practice covers these three as well. Not a complaint, I can see why this makes sense and my Jersey / Guernsey / Isle of Man customers will probably appreciate being treated as actual countries.
Comment #9
rooby commented- Setting status back to fixed so people see this post.
Yeah, maybe make a new issue and just put in a reference to this issue to say this was the cause.
Thanks for catching this.
Comment #10
DanielJohnston commentedThanks. I've created an issue at #835174: Geocoding for Guernsey, Jersey, Isle of Man to follow up on this. As soon as I created the issue, I realised my logic was wrong on this being the cause of my problems with geocoding - it was related to patching from #326665: UK cities are in state/province field and inputting locations from the three as countries rather than UK provinces.
Comment #11
hutch commentedI'm not sure if I'm swimming in the same direction or not, but I have just posted a patch in #326665: UK cities are in state/province field #38