There is a typo when replacing d in mysql.

Here is the documentation for reference:
http://dev.mysql.com/doc/refman/5.0/en/date-and-time-functions.html

CommentFileSizeAuthor
#7 views_date_sql_format_ext_3.patch1.32 KBjcmarco
#4 views_date_sql_format_ext_2.patch1.3 KBjcmarco
#2 views_date_sql_format_ext.patch1.32 KBjcmarco
#1 views_date_sql_format.patch370 bytesjcmarco

Comments

jcmarco’s picture

jcmarco commented
StatusFileSize
new views_date_sql_format.patch370 bytes
jcmarco’s picture

jcmarco commented
StatusFileSize
new views_date_sql_format_ext.patch1.32 KB

I have extended the most usual date formats

From:
http://us.php.net/manual/en/function.date.php
http://dev.mysql.com/doc/refman/5.0/en/date-and-time-functions.html
http://developer.postgresql.org/pgdocs/postgres/functions-formatting.html

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Needs work

The '%%d' is not a typo. It is there because '%d' will get processed by db_query() and will mess up any arguments to the query.

jcmarco’s picture

jcmarco commented
Category: bug » feature
Status: Needs work » Needs review
StatusFileSize
new views_date_sql_format_ext_2.patch1.3 KB

Ok, I found it while testing with more strings.
I even found that %b requires to be escaped as well.

Changed for a feature request to support more strings.

I am working in a patch for views_handler_field_date.inc to support
date formats configured with Data API, and option to support native
date_format in queries to solve problems grouping information.

jcmarco’s picture

jcmarco commented
Title: views_date_sql_format has a typo with days » Add more date format string to views_date_sql_format
merlinofchaos’s picture

merlinofchaos commented

It would be true for %b, %d, %s, %f -- I see a %s in there too. Odd that %d was covered and %s was not.

jcmarco’s picture

jcmarco commented
StatusFileSize
new views_date_sql_format_ext_3.patch1.32 KB

You were absolutely right!

The %s was wrong.

I didn't translate %f as it seems that using microseconds is not usual.
Do you consider a good idea trying to translate all the strings from http://us.php.net/manual/en/function.date.php?

robby.smith’s picture

robby.smith commented

subscribing

merlinofchaos’s picture

merlinofchaos commented
Version: 6.x-2.x-dev » 7.x-3.x-dev
Status: Needs review » Patch (to be ported)

Unsurprisingly, this does not apply to D7. COmmitted to D6 branches.

dawehner’s picture

dawehner
Primary language German
commented
Status: Patch (to be ported) » Fixed

Ported and commited.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.