First of all, thanks for this great application.

One thing that in my opinion would come in handy, is to make Extractor case-insensitive. Many news sites open their articles with a city in capitals, i.e. "NEW YORK - The mayor of New York has said that .... ".

A workaround is to add all the names also in capitals, but this will add those terms twice and is ofcourse undisireable.

CommentFileSizeAuthor
#3 753876-3_case_insensitive.patch994 bytesalex_b
#2 extractor_simple_case_insensitive.patch574 bytesmedieval111

Comments

Will White’s picture

Will White commented
Project: Managing News » Extractor
Version: 6.x-1.0-beta6 » 6.x-1.0-alpha3

Moving this to the Extractor project.

medieval111’s picture

medieval111 commented
Status: Active » Needs review
StatusFileSize
new extractor_simple_case_insensitive.patch574 bytes

I just found out that the function "_extractor_simple_lookup" is case insensitive. That function is called by "extractor_simple_extract", which is NOT case insensitive!
So I wrote a simple patch to solve that. Works for me....

alex_b’s picture

alex_b commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 753876-3_case_insensitive.patch994 bytes

It should be

if (strtolower($term_words[$i]) != strtolower($words[$pos+$i])) {

Otherwise we get matches like wash == washington

alex_b’s picture

alex_b commented
Status: Reviewed & tested by the community » Fixed

Committed, thank you.

http://drupal.org/cvs?commit=419382

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.