CVS edit link for glazer

The company I work for, VMT (www.vmtllc.com) has created a social marketing platform called SocialToaster (www.socialtoaster.com). SocialToaster is a revolutionary hosted platform that allows your supporters to automatically drive traffic to your website via their social network accounts like Facebook & Twitter, while providing you with advanced real-time marketing analytics. People using the SocialToaster module can allow their employees, friends, and fans (referred to as ambassadors) to market to their own social circles using facebook, twitter, and myspace. This module allows these ambassadors to sign up as users of the SocialToaster system, and also allows administrators to publish content to their ambassador's social networks.
CommentFileSizeAuthor
#1 socialtoaster.zip8.51 KBglazer

Comments

glazer’s picture

glazer commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new socialtoaster.zip8.51 KB

I have attached the module's code to this comment. Please review it and let me know if there are any changes that need to be made. Thank you.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work
Issue tags: +Module review

Hello, and thanks to apply for a CVS account. The motivation message should be expanded to contain more information about the proposed module, and a comparison with the existing solutions.

glazer’s picture

glazer commented

I have rewritten the motiviation message.

SocialToaster for Drupal
SocialToaster for Drupal is a module that allows a Drupal site to seamlessly integrate with the SocialToaster social marketing automation solution. This module provides for the following functionality:
Allows site owners to recruit site users to act as "Ambassadors" for the site, whereby they can assist in promoting content published on the site to their own personal social networks including Facebook, Twitter, LinkedIn, and MySpace. Ambassadors are simply website users that have a relationship to the organization the site belongs to and who want to see that organization succeed. They can be employees, customers, partners, volunteers, donors, or anybody that wants to help promote site content.
Allows these Ambassadors to go through a one-time sign-up process to link their accounts to the site via a new tab that displays on their personal profile. Help text is displayed on this tab, and can be customized for the site within the administration features of the module.
Allows site content that is published to be seamlessly promoted to the Ambassadors' networks via the SocialToaster marketing automation solution. Any content type, including CCK custom content types, can be promoted. The module adds fields to the content type submission form to allow the publisher to specify whether or not content should be promoted through SocialToaster, to indicate what the Ambassadors' status updates will be changed to be, and to give the content a title to be referenced in SocialToaster's advanced reporting and analytics.
Allows site administrators to maintain and administer the module including specifying custom help and text and connecting the module to SocialToaster.
About SocialToaster
SocialToaster is a patent-pending social marketing automation solution unlike anything else out on the market. It is a system that allows an organization to leverage a community of supporters to automatically promote website content to their own personal networks while providing social analytics and reporting. It is based on the principle that every organization has a group of people that, if asked, would be happy to help link to website content that they thought was interesting as long as it were simple and easy. SocialToaster is a solution that allows these people to do exactly that, which in turn can generate tremendous traffic and brand awareness to the site. At present SocialToaster is generating an average of 9 visitors back to the site for each post that gets created. This means that a small group of promotors, called Ambassaddors, can generate thousands of visitors each month as long as regular content is being created. This makes SocialToaster an extremely cost-effective solution for online marketing.

Installation and Dependencies
SocialToaster for Drupal requires a SocialToaster account, which can be purchased from SocialToaster.com for a one-time provisioning fee of $199, with a minimum ongoing monthly commitment of $20 per month which includes up to 40 posts. A post is defined as any time SocialToaster creates a link back to website content in a way that is going to be tracked. Additional posts are charged at a per-post fee based on volume, with the ability to cap monthly expenses. Detailed pricing can be found on the SocialToaster website.

Similar Modules
SocialToaster for Drupal connects to a 3rd party service to process requests. Examples of other modules that connect to 3rd party services are Mollom and Gigya.

Terms of Use
The SocialToaster for Drupal module is licensed under the same license as the Drupal core. Use of the module requires a valid SocialToaster account, which can be obtained from the SocialToaster.com website.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review

Thanks for your reply.

razzaque’s picture

razzaque commented

Is there any update on the status of this? We would like to have our module approved prior to going to Drupalcon SF this coming week, we are a Silver Sponsor.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno

I will review the code tomorrow.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Fixed 
  1.     'access callback' => 'user_access',

    That is the default value, and it should not be declared. 

  2.       $form['socialtoaster']['socialtoaster'] = array(
        '#type' => 'checkbox',
        '#title' => t('Allow nodes to be shared through SocialToaster'),
        '#description' => t('If checked, the <em>SocialToaster</em> sharing settings will appear on the node edit form for those who have permission to edit the node.  A share button will also appear on the node view page for people with permission to share through SocialToaster.'),
        '#default_value' => variable_get('socialtoaster_type_'. $form['#node_type']->type, 0),
     );

      $form['#submit'][] = 'socialtoaster_node_type_form_submit';
    
    }

  }

}


/**
 * Submite handler for the node_type_form element added in the hook_form_alter() above.
 */
function socialtoaster_node_type_form_submit($form, &$form_state) {
  $socialtoaster = $form_state['values']['socialtoaster']['socialtoaster'] ? 1 : 0;
  variable_set('socialtoaster_type_'. $form_state['values']['type'], $socialtoaster);

  // For some reason the node module adds the fieldset as a separate entry in the variables table... we dont want this!
  variable_del('socialtoaster_'. $form_state['values']['type']);
}

    Compare your code what the code used by upload.module, in example.

        $form['workflow']['upload'] = array(
      '#type' => 'radios',
      '#title' => t('Attachments'),
      '#default_value' => variable_get('upload_'. $form['#node_type']->type, 1),
      '#options' => array(t('Disabled'), t('Enabled')),
    );

    The problem you report is caused by the fact you declare the form field as $form['socialtoaster']['socialtoaster'], but the Drupal variable name starts with socialtoaster_type_. If you would correct the variable name, then you would not need to use a custom submission callback.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)
Issue tags: -Module review

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Module review

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Component: Miscellaneous » new project application
Issue summary: View changes