CVS edit link for gege2061

Hello,

This is my first Drupal module. It adds a flag for mark a forum comment accepted and the topic as solved.

This is a popular feature supported by many forum scripts but I found nothing for Drupal.

Preview : http://gege2061.homecomputing.fr/flag_solved.png
Sources : http://gege2061.homecomputing.fr/flag_solved.tar.gz

CommentFileSizeAuthor
#9 flag_solved.tar_.gz3.32 KBsanpi
#8 flag_solved.tar_.gz3.26 KBsanpi
#4 flag_solved.tar_.gz3.19 KBsanpi
#1 flag_solved.tar_.gz3.07 KBsanpi

Comments

sanpi’s picture

sanpi commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new flag_solved.tar_.gz3.07 KB
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work
Issue tags: +Module review

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.

As per http://drupal.org/cvs-application/requirements, the motivation message should be expanded to contain more details about the features of the proposed module, and it should include also a comparison with the existing solutions.

sanpi’s picture

sanpi commented

Thank's for your answer.

This module is based on the flag module and allows forum topic author or content administrators to mark a forum comment as "Accepted". Accept a response highlights and adds an image in the topic title.

I have not found this feature in other drupal module, I can't compare.

sanpi’s picture

sanpi commented
StatusFileSize
new flag_solved.tar_.gz3.19 KB

Minor changes:

  • Adding comments
  • Improving _flag_solved_advforum_enable (use a static variable)
  • Improving usage without advanced forum module (don't use ajax for flaging)
  • Add js only if necessary
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

As you reported the module is based on Flag, why didn't you open a feature request in that module queue to integrate the feature in the existing project?

sanpi’s picture

sanpi commented

The flag module is very versatile. Like flag_abuse, flag a message as solved causes other actions. We can imagine an interaction with the voping_api module for increase the score for an user, for example.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review
sanpi’s picture

sanpi commented
StatusFileSize
new flag_solved.tar_.gz3.26 KB

Adding support for nodecomment

sanpi’s picture

sanpi commented
StatusFileSize
new flag_solved.tar_.gz3.32 KB

fixed many bugs.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno

I will review the code tomorrow.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Fixed

Thank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)
Issue tags: -Module review

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Module review

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Component: Miscellaneous » new project application
Issue summary: View changes