qandeel.aslam@gmail.com [qandeel] [#746616]

CVS edit link for qandeel.aslam@gmail.com

As far as translation is concerned, I am planning with the maintainer of URDU translation Mr. Saad to enhance this effort to next level for this i am working on Mega project that is based on Drupal and is going to be the largest project in URDU Language ever. so we both decided yesterday that i should join the team. here is the project links where maintainer is seeking help... http://drupal.org/node/443440, here is the link were we decided to put this in Drupal's localized project http://drupal.org/node/745740

I am also developing a module that is the an enhanced version workflow module, and has very rich features like Revision based workflow, Roles grouping, Rules based workflow model where there will be one Workflow and shared states and on top of that there will be rules that will decide the behavior on a node being edited. So its kind of a Workflow Nextgeneration module, where we donot need Module_grants, Revisioning or Workflow module dependencies. Also unlike Workflow module it will have features like workflow based on per node, not per content type.....

I am working on this module very seriously and will also discuss it with Jeff Eaton (He knows me) when i feel i am on a stage to release alpha version.

Another module that i have just completed is password reset module that allows administrator to show both email and Username fields as mandatory for resetting passwords.

Comment	File	Size	Author
#19	password_reset.zip	3.54 KB	qandeel
#2	password_reset.zip	8.6 KB	qandeel
#1	password_reset.zip	2.25 KB	qandeel

Comments

Comment #1

qandeel commented 19 March 2010 at 02:27

Status:

Postponed (maintainer needs more info)

» Needs review

Status	File	Size
new	password_reset.zip	2.25 KB

Here is one of my module that i completed yesterday and its going good on one of my live site...

Comment #2

qandeel commented 19 March 2010 at 04:17

Status	File	Size
new	password_reset.zip	8.6 KB

Please refer to this post for my module attachment...

Comment #3

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 19 March 2010 at 15:40

Status:	Needs review	» Needs work
Issue tags:		+Module review

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.

As per http://drupal.org/cvs-application/requirements, the motivation message should be expanded to contain more details about the features of the proposed module, and it should include also a comparison with the existing solutions.

Comment #4

qandeel commented 20 March 2010 at 03:05

Kiam,

I really appreciate your prompt response... let me know what to do if i have another module that will be ready while my CVS application is pending...?

thanks
Qandeel

Comment #5

qandeel commented 24 March 2010 at 16:49

Hi Kiam,

I have done research on my end and it seems like there is no similar module available today... although i found this and it seems that there is a demand for this kind of feature.

http://drupal.org/node/15578#comment-1026668

http://drupal.org/node/15578#comment-896502

based on these two comments and this long thread i think my module is the answer to this.. i want it to be on drupal module list so that i can also let these user know about it...

thanks
Qandeel

Comment #8

qandeel commented 26 March 2010 at 20:53

Assigned:

Unassigned

» qandeel

I dont know if i need to Assign this to myself.. in doubt.. changing Assigned to myself

Comment #9

qandeel commented 29 March 2010 at 06:02

Another project ready for review, here is a little brief ...

This new module is enhancement to workflow module, Current workflow module has a limitation, One workflow serves only one group of Author/Editor. This new module creates another layer at top of Workflow module by creating groups... for example One workflow can server 'n' numbers of groups and those groups cannot have access to other groups node though both groups have same workflow.

This is done because in most of the cases admin ends up with lot of content types + workflows + roles..

Let me know, how to attach this module for review... its very hot and most of my clients require this kind of feature.. and i have it developed.. I want to expedite this

Thanks

Qandeel

Comment #10

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 29 March 2010 at 09:39

Assigned:	qandeel	» Unassigned
Status:	Needs work	» Needs review

We just review a theme/module per applicant.

Comment #11

qandeel commented 29 March 2010 at 15:43

Kiam,

So you want me to hold on to this new module and wait for the review for my first module to get complete and then submit this one?

Qandeel

Comment #12

Anonymous (not verified) commented 29 March 2010 at 19:19

If the first module gets approved, then there will not be the need to review a second module, as at that time you will have already a CVS account, and the possibility to create as much projects as you want (if something is not changed in the while). That is the reason I said we review just a module/theme per applicant.

Comment #13

qandeel commented 29 March 2010 at 20:58

That make sense.. then Ill wait for your review update.. in a meanwhile do let me know if you require any further information

Thanks and have a good one

Comment #14

qandeel commented 16 April 2010 at 13:55

Any update who is reviewing and when i would get response about it

Comment #15

qandeel commented 24 May 2010 at 04:05

Hi Kiam,

I have seen lot of users are getting CVS access with no delay.. then why are you guys keeping my request on hold.. are you guys really serious in business..

Thanks

Qandeel

Comment #16

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 24 May 2010 at 06:06

The only applications that are approved faster are the ones that apply to become co-maintainer.
There are applications that still needs to get a definitive response after 7 weeks they are opened; as you see, we are slowly taking care of those too.

Comment #17

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 24 May 2010 at 06:29

Assigned:

Unassigned

» avpaderno

I will review the code tomorrow morning (about 24 hours from now).

Comment #18

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 25 May 2010 at 19:15

Status:

Needs review

» Needs work

    $accounts = db_query("SELECT name FROM {users} WHERE LOWER(mail) = LOWER('%s')", $email);
    while ($paccount = db_fetch_object($accounts)) {
      // Mail login URL and instructions if username and email exists.      
      if ($paccount->name == $name) {
        $account = user_load(array('name' => $name, 'status' => 1));
        form_set_value(array('#parents' => array('account')), $account, $form_state);

      }
    }

It's possible to use user_load() to load a user object knowing the user e-mail, as reported from the documentation page:

Parameters

$array An associative array of attributes to search for in selecting the user, such as user name or e-mail address.

Then, in Drupal two users cannot use the same e-mail address.

License files cannot be committed in Drupal.org repository. The license file is already added from the packaging script, and a CVS script blocks the temptative to commit such files.
The code of the proposed module is not complete; as per requirements, the code must be complete.


; Information added by drupal.org packaging script on 2009-06-15
project = "password_reset"

That line is already added by the packaging script, and it should be removed.

Comment #19

qandeel commented 5 June 2010 at 14:14

Status	File	Size
new	password_reset.zip	3.54 KB

Hi Kiamlaluno,

I have removed the License file.. also removed the Packaging script information

So my module was written to accommodate features like password reset by passing two values username and email and it also accomodate in a cases where sharedemail module is used. It works and provide extra functionality by adding two fields on password reset form.. and if both matches then return the password.

Reason i am not using user_load() with email attributes because i want to make my module usable in both scenarios.. with and without sharedemail module

Anyway for your sake i am adding comment in code to explain that if that module (sharedemail) is used then this condition will run, and in this scenario if sharedemail module is enable and we have common email address we cannot use user_load(), because it will always return the first value in the record set.. please see user_load function.

Comment #20

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 5 June 2010 at 15:10

Status:

Needs work

» Needs review

Comment #21

qandeel commented 9 June 2010 at 16:06

Hi Kiamlaluno,

I have lot of modules to work on and one of that one is controlpanel project - http://drupal.org/project/controlpanel, the project owner want me to have CVS account to co-maintain his project.. please see the post from the project owner here..

http://drupal.org/node/822908

Also let me know if you need any more access

Thanks