Applying an Order Discount

I think I either don't understand the workings of the uc_discount module, or I've found a bug. In uc_discount.module, the function uc_discount_calculate_discounts, we have the code to evaluate the order discounts:

  //Calculate overall order discounts
  // Pull the "calculate_discounts" trigger in such a way to get the results.
  $predicates = ca_load_trigger_predicates('calculate_order_discounts');
  foreach ($predicates as $predicate) {
    if (ca_evaluate_conditions($predicate, $arguments)) {
      $discounts = ca_perform_actions($predicate, $arguments);
      foreach ((array) $discounts as $i => $discount) {
        if ($predicate['#actions'][$i]['#name'] == 'uc_discount_action_get_order_discount' && $discount) {
          // Allow successive discounts to inspect this discount by putting
          // it in the order object.
          $order->discounts[$id] = array(
            'id' => $id,
            'title' => check_plain($predicate['#actions'][$i]['#title']),
            'amount' => $discount,
            'weight' => variable_get('uc_li_discount_weight', 5) + $predicate['#actions'][$i]['#settings']['line_item_weight'] / 10,
          );
          $id++;
        }
      }
    }
  }

My problem is with this line:

         if ($predicate['#actions'][$i]['#name'] == 'uc_discount_action_get_order_discount' && $discount) {

I want to add my own action/logic that is executed on an order to add an overall order discount, not on any specific line item or product. No matter what, however, it looks like the predicates and discounts are only being applied if the action is "uc_discount_action_get_order_discount". This means that if we're using a custom hook/action, or if we're using a php executed action, or really anything that is not the "Apply Discount", then it doesn't get picked up by the discount module. This is happening, even though in the Conditional Actions config, I made a predicate that is of type "calculate_order_discounts". This means that the check "$predicate['#actions'][$i]['#name'] == 'uc_discount_action_get_order_discount'" is unnecessarily limiting, and incredibly limits the usability of this type of predicate. In other words, the only type of product discount that can be applied is to the apply discount action.

I propose that we modify the above to the following:

  //Calculate overall order discounts
  // Pull the "calculate_discounts" trigger in such a way to get the results.
  $predicates = ca_load_trigger_predicates('calculate_order_discounts');
  foreach ($predicates as $predicate) {
    if (ca_evaluate_conditions($predicate, $arguments)) {
      $discounts = ca_perform_actions($predicate, $arguments);
      foreach ((array) $discounts as $i => $discount) {
        if ($discount) {
          // Allow successive discounts to inspect this discount by putting
          // it in the order object.
          $order->discounts[$id] = array(
            'id' => $id,
            'title' => check_plain($predicate['#actions'][$i]['#title']),
            'amount' => $discount,
            'weight' => variable_get('uc_li_discount_weight', 5) + $predicate['#actions'][$i]['#settings']['line_item_weight'] / 10,
          );
          $id++;
        }
      }
    }
  }

Only one line changed. This reduces the if statement to only check for the discount. If so, it applies as appropriate. I believe that this is correct, and it implements the behavior as I understand that it should.

If this is correct, please let me know and I can supply a patch file.

If this is incorrect, please let me know, and let me know why it is incorrect.