It would be nice to be able to use an Image and Text link as described on http://www.addthis.com/help/custom-buttons.

CommentFileSizeAuthor
#4 addthis-imageandtext.patch4.23 KBvesapalmu
#1 addthis-742988-1.patch3.8 KBjromine

Comments

jromine’s picture

jromine commented
Status: Active » Needs review
StatusFileSize
new addthis-742988-1.patch3.8 KB

Patch for 6.x-2.9 attached.

BioALIEN’s picture

BioALIEN commented
Version: 6.x-2.9 » 6.x-2.x-dev
Priority: Normal » Critical

If we're expanding the API to support image with text then how about including the option of only text also in the mix? The link http://www.addthis.com/help/custom-buttons demonstrates the API can handle such choice and I am surprised this module is not taking advantage of this.

As this feature gives a wide range of display choice to the end user, I am marking as critical.

vesapalmu’s picture

vesapalmu commented

I am currently a bit careful when it comes down to implementing more of Addthis.com API. Full support of all API functionality will definitely make it to HEAD, but getting more of it supported in D6 2.x will require more patches. I will commit this patch after 2.10 is released so that people can review it on dev first.

vesapalmu’s picture

vesapalmu commented
Status: Needs review » Needs work
StatusFileSize
new addthis-imageandtext.patch4.23 KB

I rewrote the patch slightly. This patch would result in always having extra span after the button even when it's not used. Themers, what do you think about this? Is it better to always have the extra span or only when it's being used?

This patch works against 2.10 or current 2.x-dev.